-
-
Notifications
You must be signed in to change notification settings - Fork 967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL params are not available inside middleware on the root router #892
Comments
I have the same issue |
This behavior is due to the way the chi router handles middleware and route patterns. When you register a middleware using r.Use() at the root level, the middleware is applied to all routes, including routes that do not have any URL parameters. As a result, when the middleware tries to extract the "id" parameter using chi.URLParam(r, "id"), it doesn't find it because the current route doesn't have an "id" parameter. |
The behavior you describe would be what I would expect to be the behavior, but the problem is that when I execute an HTTP request for a route which does have an |
v1Router := chi.NewRouter()
v1Router.Route("/test/{id}", func(r chi.Router) {
r.Use(Middleware)
r.Get("/", handler.getHandler)
r.Patch("/", handler.updateHandler)
r.Delete("/", handler.deleteHandler)
}) |
When I create a middleware to log the
id
URL parameter, which exists in the route I request, the value is always empty. I do get a value inside the handler itselfWhen I move this code to a
Group
, the URL param will become available inside the middleware.I think this behavior is quite strange and prone to errors
Tested with the latest version (5.0.11)
The text was updated successfully, but these errors were encountered: