You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It is currently quite difficult for people to figure out how to approve a MR. They need to know to first switch to the "Files changed" tab, then they need to pretend to start a review by clicking on the "Review" button, then realize that the comment is optional, and finally click the "Approve" button.
All of this is decidedly non-obvious to anyone that hasn't been shown it before, and difficult to remember even if you have.
Please add an Approve button on the initial conversation page of a MR.
Screenshots
No response
The text was updated successfully, but these errors were encountered:
This UI closely mirrors what GitHub has and the primary color should indicate the primary action for a reviewer. The location is so that the reviewer is forced to look at code, which is generally a good practice I guess because no one should blindly approve PRs.
Yes, I definitely agree that blindly approving PRs is to be avoided.
However, many reviews don't happen on the "Files Changes" tab, with reviewers looking at commits individually on the "Commits" tab, or even in a clone. Even when changes are reviewed there, people note their comments on individual lines, resolve those conversations as each one is addressed, and then end up at a loss at to what to do next - they've just finished their review, so have no reason to click on a button that would seem to start a new review.
An example of what I’d hope to see is the approach that Gitlab uses, where it shows an “Approve” button on its overview page:
For Gitea, it would be nicer if it showed a similar button next to the “doesn't have enough approvals” message, perhaps like this (don't particularly care whether it's blue, or green, or whatever):
Feature Description
It is currently quite difficult for people to figure out how to approve a MR. They need to know to first switch to the "Files changed" tab, then they need to pretend to start a review by clicking on the "Review" button, then realize that the comment is optional, and finally click the "Approve" button.
All of this is decidedly non-obvious to anyone that hasn't been shown it before, and difficult to remember even if you have.
Please add an Approve button on the initial conversation page of a MR.
Screenshots
No response
The text was updated successfully, but these errors were encountered: