[Editor] Add support for displaying unsigned integers in the inspector #89529
+109
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
commented
Mar 16, 2024
AThousandShips
force-pushed
the
range_improve
branch
from
51db66a
to
9a5daf3
Compare
AThousandShips
force-pushed
the
range_improve
branch
from
9a5daf3
to
e1f5a81
Compare
Added these hints to shader uniforms, which is what inspired this improvement Also made improvements to handling of vector inspector
AThousandShips
force-pushed
the
range_improve
branch
from
e1f5a81
to
b6bf138
Compare
RedMser
reviewed
May 20, 2024
| @@ -2764,7 +2764,7 @@ | |||
| <constant name="PROPERTY_HINT_RANGE" value="1" enum="PropertyHint"> | |||
| Hints that an [int] or [float] property should be within a range specified via the hint string [code]"min,max"[/code] or [code]"min,max,step"[/code]. The hint string can optionally include [code]"or_greater"[/code] and/or [code]"or_less"[/code] to allow manual input going respectively above the max or below the min values. | |||
| [b]Example:[/b] [code]"-360,360,1,or_greater,or_less"[/code]. | |||
| Additionally, other keywords can be included: [code]"exp"[/code] for exponential range editing, [code]"radians_as_degrees"[/code] for editing radian angles in degrees (the range values are also in degrees), [code]"degrees"[/code] to hint at an angle and [code]"hide_slider"[/code] to hide the slider. | |||
| Additionally, other keywords can be included: [code]"exp"[/code] for exponential range editing, [code]"radians_as_degrees"[/code] for editing radian angles in degrees (the range values are also in degrees), [code]"degrees"[/code] to hint at an angle and [code]"hide_slider"[/code] to hide the slider, and [code]"display_unsigned"[/code] to allow signed integers to be displayed as unsigned (this is especially useful with [PackedInt32Array]). | |||
There was a problem hiding this comment.
Suggested change
| Additionally, other keywords can be included: [code]"exp"[/code] for exponential range editing, [code]"radians_as_degrees"[/code] for editing radian angles in degrees (the range values are also in degrees), [code]"degrees"[/code] to hint at an angle and [code]"hide_slider"[/code] to hide the slider, and [code]"display_unsigned"[/code] to allow signed integers to be displayed as unsigned (this is especially useful with [PackedInt32Array]). | |
| Additionally, other keywords can be included: [code]"exp"[/code] for exponential range editing, [code]"radians_as_degrees"[/code] for editing radian angles in degrees (the range values are also in degrees), [code]"degrees"[/code] to hint at an angle, [code]"hide_slider"[/code] to hide the slider, and [code]"display_unsigned"[/code] to allow signed integers to be displayed as unsigned (this is especially useful with [PackedInt32Array]). |
"and" appears twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added these hints to shader uniforms, which is what inspired this improvement
Also made improvements to handling of vector inspector
Still in progress with some details to work out, but basically ready, works well with the specific use case, limited at the moment but useful for the specific use of handling shaders, where editing unsigned values is very difficult from the editor
Considering it a feature, but it technically covers a broken or missing editor feature, I think it speaks for itself in this format, but can open a proposal if desired, but I don't think there's anything more to discuss except implementation details
It's of very limited use for
intbut forPackedInt32ArrayandVector2/3/4iit's very potentSee for background:
PropertyInfos #89488 (comment)uvecshader uniform parameters as signed #92064