Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor issue with tools when SubViewport is selected #92072

Open
JekSun97 opened this issue May 18, 2024 · 3 comments
Open

Minor issue with tools when SubViewport is selected #92072

JekSun97 opened this issue May 18, 2024 · 3 comments

Comments

@JekSun97
Copy link

JekSun97 commented May 18, 2024

Tested versions

Happens in Godot 4.3 dev, but does not happen in 4.2.2

System information

Godot v4.3.dev6 - Windows 10.0.19045 - Vulkan (Forward+) - dedicated Radeon RX 560 Series (Advanced Micro Devices, Inc.; 31.0.14001.45012) - Intel(R) Core(TM) i5-4570 CPU @ 3.20GHz (4 Threads)

Issue description

When I select a SubViewport node or its child nodes, then select the move or scale or rotation tool, and hold down the mouse, a selection rectangle appears.
This is hardly a significant problem, but it's worth knowing about.
in 4.2 there is no selection.

0518.1.mp4

Steps to reproduce

Select the SubViewport and simulate its movement in the scene using the move tool

Minimal reproduction project (MRP)

Not required

@ryevdokimov
Copy link
Contributor

It's due to #86804.

I don't think this is a bug. You're not supposed to be able to interact with these type of Nodes (Popups, Timers, Subviewports, etc.) with the editor gizmo, so it defaults to trying to select something that you can.

@JekSun97
Copy link
Author

JekSun97 commented May 20, 2024

It's due to #86804.

I don't think this is a bug. You're not supposed to be able to interact with these type of Nodes (Popups, Timers, Subviewports, etc.) with the editor gizmo, so it defaults to trying to select something that you can.

Then it would be more convenient to make sure that when selecting a SubViewport node, unused tools are hidden or inactive.

Either way, it doesn't look very nice compared to 4.2 when your cursor indicates that it should move something but instead it selects

@ryevdokimov
Copy link
Contributor

ryevdokimov commented May 20, 2024

What do you mean by unused? That PR makes all tools useable in that state by allowing them to select nodes if a node that can use the gizmo isn’t already selected (with the exception of the select tool, which can always select).

Either way, it doesn't look very nice compared to 4.2 when your cursor indicates that it should move something but instead it selects

It can't move anything when the SubViewport is selected, which is why is defaults to selecting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Not Critical
Development

No branches or pull requests

4 participants