Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/text/unicode/runenames: incorrect rune name on the aix-ppc64 builder #67526

Closed
findleyr opened this issue May 20, 2024 · 5 comments
Closed
Assignees
Labels
arch-ppc64x NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@findleyr
Copy link
Contributor

While investigating #65072, I added a test to narrow down an aix-ppc64 builder failure to the x/text package. This is the entire content of that test (Source):

func TestHoverLit_Issue65072(t *testing.T) {
	// This test attempts to demonstrate a root cause of the flake reported in
	// https://github.com/golang/go/issues/65072#issuecomment-2111425245 On the
	// aix-ppc64 builder, this rune was sometimes reported as "LETTER AMONGOLI".
	if got, want := runenames.Name(0x2211), "N-ARY SUMMATION"; got != want {
		t.Fatalf("runenames.Name(0x2211) = %q, want %q", got, want)
	}
}

Sample failure:
https://build.golang.org/log/1627876befc9a306fd0cb1b6c9f21c9cdb42c1df

--- FAIL: TestHoverLit_Issue65072 (0.00s)
    hover_test.go:18: runenames.Name(0x2211) = "LETTER AMONGOLI", want "N-ARY SUMMATION"

I've not investigated further, but it appears that x/text is somehow returning an incorrect rune name on this builder.

CC @golang/aix @golang/ppc64

@gopherbot gopherbot added this to the Unreleased milestone May 20, 2024
@gopherbot
Copy link

Change https://go.dev/cl/586777 mentions this issue: gopls/internal/golang: remove test debugging aix-ppc64 issue

@findleyr
Copy link
Contributor Author

I'm removing the above test from gopls now that this is confirmed not to be a gopls issue. However, I'll note that the test did not fail deterministically. Instead, it was flaky, which is surprising given the nature of the failure, and seems to confirm that this is a bug:
image

@findleyr
Copy link
Contributor Author

The original failures started around May 2nd. Looking at CLs around that time, this looks like a potential culprit:
https://go.dev/cl/581937

CC @dr2chase @eliben @pmur

@findleyr findleyr modified the milestones: Unreleased, Go1.23 May 20, 2024
@findleyr findleyr added NeedsFix The path to resolution is known, but the work has not been done. arch-ppc64x labels May 20, 2024
@pmur
Copy link
Contributor

pmur commented May 20, 2024

Yes, that is my suspicion too. I'll investigate.

@pmur pmur self-assigned this May 20, 2024
gopherbot pushed a commit to golang/tools that referenced this issue May 20, 2024
Remove TestHoverLit_Issue65072 now that the aix-ppc64 bug is confirmed
and reported. Instead, update the note for the conditionally skipped
basiclit.txt.

Updates golang/go#67526

Change-Id: Id7dd54006e015ac6d8c06c0abe022d77826f71b0
Reviewed-on: https://go-review.googlesource.com/c/tools/+/586777
Reviewed-by: Peter Weinberger <pjw@google.com>
Auto-Submit: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@gopherbot
Copy link

Change https://go.dev/cl/586915 mentions this issue: cmd/compile/internal/ssa: fix ppc64 merging of (CLRLSLDI (SRD ...))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-ppc64x NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants