You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While investigating #65072, I added a test to narrow down an aix-ppc64 builder failure to the x/text package. This is the entire content of that test (Source):
func TestHoverLit_Issue65072(t *testing.T) {
// This test attempts to demonstrate a root cause of the flake reported in
// https://github.com/golang/go/issues/65072#issuecomment-2111425245 On the
// aix-ppc64 builder, this rune was sometimes reported as "LETTER AMONGOLI".
if got, want := runenames.Name(0x2211), "N-ARY SUMMATION"; got != want {
t.Fatalf("runenames.Name(0x2211) = %q, want %q", got, want)
}
}
I'm removing the above test from gopls now that this is confirmed not to be a gopls issue. However, I'll note that the test did not fail deterministically. Instead, it was flaky, which is surprising given the nature of the failure, and seems to confirm that this is a bug:
Remove TestHoverLit_Issue65072 now that the aix-ppc64 bug is confirmed
and reported. Instead, update the note for the conditionally skipped
basiclit.txt.
Updates golang/go#67526
Change-Id: Id7dd54006e015ac6d8c06c0abe022d77826f71b0
Reviewed-on: https://go-review.googlesource.com/c/tools/+/586777
Reviewed-by: Peter Weinberger <pjw@google.com>
Auto-Submit: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
While investigating #65072, I added a test to narrow down an aix-ppc64 builder failure to the x/text package. This is the entire content of that test (Source):
Sample failure:
https://build.golang.org/log/1627876befc9a306fd0cb1b6c9f21c9cdb42c1df
I've not investigated further, but it appears that x/text is somehow returning an incorrect rune name on this builder.
CC @golang/aix @golang/ppc64
The text was updated successfully, but these errors were encountered: