Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/perf/app/dashboard: automate the branch list #67530

Open
findleyr opened this issue May 20, 2024 · 1 comment
Open

x/build/perf/app/dashboard: automate the branch list #67530

findleyr opened this issue May 20, 2024 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) Friction Nuisances that make good candidates for our "friction" fix-it weeks NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@findleyr
Copy link
Contributor

I started working on this today as a warmup, then realized I had bitten off more than I could chew, so am instead filing a reminder issue for the next team-wide fixit:

It would be nice if:

  1. The branch list here were not hard-coded, and
  2. There were an alias for "latest release branch" in the query string, for example ?branch=release.

In addition to avoiding a maintenance task every release cycle, this would allow us to have a permalink to x/tools/gopls benchmarks, which only run on the latest release. (right now, I have a Google internal short link that I keep updating).

Never a big enough deal to prioritize, but apparently a manual task performed by multiple team members! A good candidate for a fixit week.

@findleyr findleyr added the Friction Nuisances that make good candidates for our "friction" fix-it weeks label May 20, 2024
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label May 20, 2024
@gopherbot gopherbot added this to the Unreleased milestone May 20, 2024
@dmitshur
Copy link
Contributor

Noting here that the maintner service's ListGoReleases API call might be useful for this.

Sample maintq list-releases output
$ go run golang.org/x/build/maintner/maintq@latest list-releases
releases: <
  major: 1
  minor: 22
  patch: 3
  tag_name: "go1.22.3"
  tag_commit: "adbfb672ba485630d75f8b5598228a63f4af08a4"
  branch_name: "release-branch.go1.22"
  branch_commit: "185457da9bf7b617565e05e4ba95d89095fe7613"
>
releases: <
  major: 1
  minor: 21
  patch: 10
  tag_name: "go1.21.10"
  tag_commit: "752b009010df021c45f620e683ec062d22b552bf"
  branch_name: "release-branch.go1.21"
  branch_commit: "6f5219571c5fde780573918ba334030f002ce00e"
>

@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) Friction Nuisances that make good candidates for our "friction" fix-it weeks NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

4 participants