Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neurd Clip Instability [RNaD] #1178

Open
spktrm opened this issue Feb 14, 2024 · 1 comment
Open

Neurd Clip Instability [RNaD] #1178

spktrm opened this issue Feb 14, 2024 · 1 comment

Comments

@spktrm
Copy link
Contributor

spktrm commented Feb 14, 2024

In the paper and open spiel implementation, the neurd clip value is set to 10k.

From my testing, this is a source of major instability since the vtrace operator frequently outputs very large q value targets - this flows directly to the advantage estimation. The large clip bounds don't do much to prevent extremely large policy loss values.

Setting this value to something lower eg 10 makes for more consistent training.

Could the authors comment on why such a large clip value was used / didn't introduce this instability.

Thank you.

P.S. the readme value incorrectly reports a clip value of 100k instead of 10k as used.

@lanctot
Copy link
Collaborator

lanctot commented Feb 19, 2024

@perolat any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants