Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tempo-distributed] - Unclear override configuation for tempo-distributed #3681

Open
Nierhoff opened this issue May 15, 2024 · 1 comment
Open

Comments

@Nierhoff
Copy link

Nierhoff commented May 15, 2024

Describe the bug
I am trying to increase the rate limits in tempo, deployed using helm and the chart tempo-distributed and has run into issues understanding the documentation.

To Reproduce
Steps to reproduce the behavior:
Deployed using command:
helm install tempo-distributed grafana/tempo-distributed --namespace tempo --create-namespace --values distributed.yaml

the value file "distributed.yaml" content:

storage:
  trace:
    backend: s3
    s3:
      bucket: "tempo-traces"
      endpoint: minio.minio.svc.cluster.local:80
      access_key: tempo
      secret_key: REPLACE
      forcepathstyle: true
      insecure: true

global_overrides:
  per_tenant_override_config: /runtime-config/overrides.yaml
overrides: |-
  overrides:
    defaults:
      ingestion:
        burst_size_bytes: 20000000 # 20MB
        rate_limit_bytes: 20000000 # 20MB
        max_traces_per_user: 10000
        ingestion_burst_size_bytes: 20000000 # 20MB
        ingestion_rate_limit_bytes: 20000000 # 20MB
      global:
        max_bytes_per_trace: 20000000 # 20MB
    "*":
      ingestion:
        burst_size_bytes: 20000000 # 20MB
        rate_limit_bytes: 20000000 # 20MB
        max_traces_per_user: 10000
        ingestion_burst_size_bytes: 20000000 # 20MB
        ingestion_rate_limit_bytes: 20000000 # 20MB
      global:
        max_bytes_per_trace: 20000000 # 20MB

ingester:
   replicas: 1

traces:
  otlp:
    http:
      enabled: true
    grpc:
      enabled: true

I have seen multiple errors: the current is: "field ingestion not found in type overrides.LegacyOverrides"

The question is

  1. How should "global_overrides" be used ?
  2. what is the correct format for "overrides:" ?

I have been trying to use this as a guide https://grafana.com/docs/tempo/latest/configuration/#runtime-overrides

Expected behavior
I am sure this is me not fully understanding the documentation. A single example for a value file for my version (1.9.9) would be much appreciated, where typical rate limit configuation is done.
It might be related to grafana/helm-charts#2802

Environment:

  • Infrastructure: kubernetes
  • Deployment tool: helm
  • helm Chart version: 1.9.9
  • Tempo version: 2.4.1

Link to issue in helm-chart repo:
grafana/helm-charts#3134

@Nierhoff Nierhoff changed the title Unclear override configuation for tempo-distributed [Tempo-distributed] - Unclear override configuation for tempo-distributed May 16, 2024
@pantuza
Copy link

pantuza commented Jun 11, 2024

There is a bug on the distributed-tempo Helm Chart while parsing this new overrides block.
I have added the following comment on a issue describing how to workaround this problem.

Tempo itself is working as expected. If your final yaml file after Helm compilation ends up with a overrides block with proper content, it will run correctly. The issue is that the Helm Chart isn't generating the overrides block properly.

Also, in your specific case of this message (field ingestion not found in type overrides.LegacyOverrides), Tempo is saying that the program wasn't able to parse your overrides configuration and then falls back to Legacy Overrides configuration.
It happens right here in the code. Maybe it can help you out while troubleshooting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants