-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dashboard should show default title based on metric being graphed #8579
Comments
To implement default titles for metrics being graphed, follow these steps:
References/backend/model/model.go |
/bounty $50 |
💎 $50 bounty • Highlight (YC W23)Payment will be awarded to the first person to successfully merge a PR meeting all requirements. In the event that multiple PRs are submitted for the issue, we will award payment to the highest quality PR (the one that has cleanest code, best test coverage, most thorough, etc.). Steps to solve:
Thank you for contributing to highlight/highlight! Add a bounty • Share on socials
|
@Vadman97 |
@neo773 updated the description, thanks |
I would like to work on this. |
@ezhil56x please see the description. the default is currently |
I would like to work on this |
@ezhil56x see #8579 (comment) for instructions to get started - feel free to work on this issue. |
/attempt #8579
|
/attempt #8579
|
💡 @rajeshj11 submitted a pull request that claims the bounty. You can visit your bounty board to reward. |
#8602) fixes: #8579 /claim #8579 ## Summary case 1: If the graph is created/edited without any title it will pick from function type and metric. [functionType(metric)] case 2: If the user wants to give a proper name to it, they can fill in the title of their choice. The user's title will be given a higher priority irrespective of the updation of function and metric. note: If the user wants the system to pick the title. Make the title empty. It will automatically pick the title based on function type and metric. <!-- Ideally, there is an attached GitHub issue that will describe the "why". If relevant, use this section to call out any additional information you'd like to _highlight_ to the reviewer. --> ## How did you test this change? <!-- Frontend - Leave a screencast or a screenshot to visually describe the changes. --> https://www.loom.com/share/9fd9a1e000d84c5098afe7330f0dc6e5 ## Are there any deployment considerations? <!-- Backend - Do we need to consider migrations or backfilling data? --> No ## Does this work require review from our design team? No <!-- Request review from julian-highlight / our design team -->
🎉🎈 @rajeshj11 has been awarded $50! 🎈🎊 |
The default title of the chart should be updated to the graphed value once one is picked.
ie. in this case, the
metric view title
should be set toCountDistinct(Identifier)
The text was updated successfully, but these errors were encountered: