Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async issue on send text command #117188

Closed
p1rmas opened this issue May 10, 2024 · 2 comments · Fixed by #117325
Closed

Async issue on send text command #117188

p1rmas opened this issue May 10, 2024 · 2 comments · Fixed by #117325

Comments

@p1rmas
Copy link

p1rmas commented May 10, 2024

The problem

It seems that this integration blocks the operation of the Home Assistant when we send a text command.
For example, after sending the command "Bathroom light on", the Google Assistant SDK is waiting for a response, but it does not receive it, and after about 10 seconds I get the Google Assistant SDK response that the integration of my assistant could not be reached.
Immediately after the Google Assistant SDK response (cannot reach my Google Assistant integration), a command occurs - the light in the bathroom is turned on.
You can see the sequence of steps for the Google Assistant SDK and Google Assistant integrations in the logs I provided.

In addition, if I try to perform other commands in Home Assistant while waiting for a response from the Google Assistant SDK, they are inactive until a response from the Google Assistant SDK is received.

What version of Home Assistant Core has the issue?

core-2024.5.2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Google Assistant SDK

Link to integration documentation on our website

https://www.home-assistant.io/integrations/google_assistant_sdk

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

2024-05-10 12:49:18.969 DEBUG (MainThread) [homeassistant.components.google_assistant_sdk.helpers] command: bathroom light on
response: None
2024-05-10 12:49:18.998 DEBUG (MainThread) [homeassistant.components.google_assistant.smart_home] Processing message:
{'inputs': [{'context': {'locale_country': 'US', 'locale_language': 'en'},
             'intent': 'action.devices.EXECUTE',
             'payload': {'commands': [{'devices': [{'customData': {'httpPort': 8***,
                                                                   'uuid': '3fdb***d8f1',
                                                                   'webhookId': '5f15***2905'},
                                                    'id': 'light.bathroom_light_switch'}],
                                       'execution': [{'command': 'action.devices.commands.OnOff',
                                                      'params': {'on': True}}]}]}}],
 'requestId': '108747768714***'}
2024-05-10 12:49:19.066 DEBUG (MainThread) [homeassistant.components.google_assistant.report_state] Scheduling report state for light.bathroom_light_switch: {'online': True, 'on': True}
2024-05-10 12:49:20.380 DEBUG (MainThread) [homeassistant.components.google_assistant.http] Response on https://homegraph.googleapis.com/v1/devices:reportStateAndNotification with data {'requestId': 'de91636a5e834883bc598***', 'agentUserId': '954b7a107c574ebab***', 'payload': {'devices': {'states': {'light.bathroom_light_switch': {'online': True, 'on': True}}}}} was {
  "requestId": "de91636a5e834883bc598***"
}

2024-05-10 12:49:21.708 DEBUG (MainThread) [homeassistant.components.google_assistant.report_state] Scheduling report state for light.bathroom_light_switch: {'online': True, 'on': False}
2024-05-10 12:49:22.914 DEBUG (MainThread) [homeassistant.components.google_assistant.http] Response on https://homegraph.googleapis.com/v1/devices:reportStateAndNotification with data {'requestId': '6ef9053911d44ec0bc***', 'agentUserId': '954b7a107c574ebab05e1***', 'payload': {'devices': {'states': {'light.bathroom_light_switch': {'online': True, 'on': False}}}}} was {
  "requestId": "6ef9053911d44ec0bc14e1***"
}

Additional information

No response

@home-assistant
Copy link

Hey there @tronikos, mind taking a look at this issue as it has been labeled with an integration (google_assistant_sdk) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of google_assistant_sdk can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign google_assistant_sdk Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


google_assistant_sdk documentation
google_assistant_sdk source
(message by IssueLinks)

@tronikos
Copy link
Contributor

Thanks! I'm surprised this went unnoticed for so long. I'm fixing it in #117325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants