Trim search inputs #20825
Merged
Trim search inputs #20825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steverep
approved these changes
May 21, 2024
|
I think this is okay, but I wonder if we should make sure to trim other pickers as well (e.g. area, device, etc.). We would need to make sure the user cannot set an area or other name with leading or trailing white space in the first place, otherwise it'd be a breaking change without a core change to trim everything. |
|
It can be useful to search with leading space some time, but I agree, it's not really a common use case (But I sometime use it 😅) so for me it's not a bug fixes but a behavior change and I'm ok with that one. Searching for "porte"
Searching for " porte"
|
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Trim leading and trailing whitespaces (also includes newlines and tabs)
See #20814 and #13783 for more information.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: