Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to html-webpack-plugin 4 #61

Open
jantimon opened this issue Sep 7, 2018 · 7 comments
Open

Upgrade to html-webpack-plugin 4 #61

jantimon opened this issue Sep 7, 2018 · 7 comments

Comments

@jantimon
Copy link

jantimon commented Sep 7, 2018

The html-webpack-plugin version 4 is getting closer to a release.
Many information can be found in this pr: jantimon/html-webpack-plugin#953

A static version property was added:
https://github.com/jantimon/html-webpack-plugin/blob/d65b37d2c588047e0d81a38f4645fcdb3ead0b9e/index.js#L915-L927

The event system was changed alot to work with the new features:

Could you please give the new events a try and let me know if they work for your case?
https://github.com/jantimon/html-webpack-plugin/tree/webpack-4#events

beforeAssetTagGeneration hook

    AsyncSeriesWaterfallHook<{
      assets: {
        publicPath: string,
        js: Array<{string}>,
        css: Array<{string}>,
        favicon?: string | undefined,
        manifest?: string | undefined
      },
      outputName: string,
      plugin: HtmlWebpackPlugin
    }>

alterAssetTags hook

    AsyncSeriesWaterfallHook<{
      assetTags: {
        scripts: Array<HtmlTagObject>,
        styles: Array<HtmlTagObject>,
        meta: Array<HtmlTagObject>,
      },
      outputName: string,
      plugin: HtmlWebpackPlugin
    }>

alterAssetTagGroups hook

    AsyncSeriesWaterfallHook<{
      headTags: Array<HtmlTagObject | HtmlTagObject>,
      bodyTags: Array<HtmlTagObject | HtmlTagObject>,
      outputName: string,
      plugin: HtmlWebpackPlugin
    }>

afterTemplateExecution hook

    AsyncSeriesWaterfallHook<{
      html: string,
      headTags: Array<HtmlTagObject | HtmlTagObject>,
      bodyTags: Array<HtmlTagObject | HtmlTagObject>,
      outputName: string,
      plugin: HtmlWebpackPlugin,
    }>

beforeEmit hook

    AsyncSeriesWaterfallHook<{
      html: string,
      outputName: string,
      plugin: HtmlWebpackPlugin,
    }>

afterEmit hook

    AsyncSeriesWaterfallHook<{
      outputName: string,
      plugin: HtmlWebpackPlugin
    }>
@Jorybraun
Copy link

Running into this problem now, is there any information about the hooks for webpack-concat-plugin. Ill just inject it manually as it stopped working.

@Jorybraun
Copy link

im about to make a pr but im not sure which branch to make the PR into.

@ymaz
Copy link

ymaz commented Apr 30, 2019

I'm using "html-webpack-plugin": "4.0.0-alpha.2",
and that example above is not working for me:

Inject to html by hand
doctype html
...
    script(src=htmlWebpackPlugin.files.webpackConcat.flexible)
...

this part htmlWebpackPlugin.files.webpackConcat is not available under the htmlWebpackPlugin.files
is that expected or I'm doing something wrong?
my current settings are

const buildConfig = {
  inject: false,
  template: paths.appHtml,
};

@gvince01
Copy link

Hi @ymaz, did you ever resolve that issue? I've got exactly the same issue whereby i'm trying to access htmlWebpackPlugin.files.webpackConcat but it's is not available under the htmlWebpackPlugin.files

@Jorybraun
Copy link

Jorybraun commented Apr 23, 2020

@gvince01 my PR resolved my initial issue, I think this repo is dead.

Perhaps we should fork it and make a new npm package for webpack concat, it's been a year since my PR was made

#71

I'd be happy to maintain this

Waiting on this to get approved actually really f'd me up at a previous job

@gvince01
Copy link

@Jorybraun Yeah I agree regarding forking it. Especially considering this plugin is still referenced in the html-webpack-plugin readme. That'd be great if you are happy to maintain it.

@Jorybraun
Copy link

@gvince01 im suprised more people don't have these issues: this plugin has 28,537 weekly downloads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants