Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run with webpack 5 #84

Open
erichstark opened this issue Apr 8, 2021 · 6 comments
Open

Run with webpack 5 #84

erichstark opened this issue Apr 8, 2021 · 6 comments

Comments

@erichstark
Copy link

Does anybody have success to run this plugin with webpack 5?

@mcler
Copy link

mcler commented Apr 8, 2021

Does anybody have success to run this plugin with webpack 5?

You can check out my fork https://github.com/mcler/webpack-concat-plugin
All key differences are mentioned in my pull request #83

@erichstark
Copy link
Author

Thanks @mcler. I will look at it.
Original plugin didn't work so I have found this one https://github.com/damorej-at-theinstitutes/webpack-concat-files-plugin. But I need something simpler for concate files, not bundling with webpack closure. It works, but it seems very slow.

@erichstark
Copy link
Author

This update for webpack 5 works. @hxlniada could you please look at it and release?

@mcler
Copy link

mcler commented Apr 22, 2021

@erichstark I think release is not going to happen, so i published my fork https://www.npmjs.com/package/@mcler/webpack-concat-plugin
My company strongly depends on this plugin, so I will maintain it.

@Labituser
Copy link

@mcler I saw in 4.1.3 release of your package, you reduce globby dependency from 11.0.3 to 8.0.2. After this globby dependency of set-value package causes a critical vulnerability issue. Can you at least increase globby to 10.0.0 to avoid this issue. Or again publish 4.1.2 (I know this is not the best approach, but at least it will solve my problem 😇.

@mcler
Copy link

mcler commented Nov 9, 2021

@Labituser

  1. I opened Issues page in my repo, so anyone would be able communicate about package there
  2. I had major problem with globby: it reportedly didn't work on Windows systems. Also I don't have one myself, unable to test it properly.
  3. v4.1.2 was never released on npm, but you may be able to install version tag from GitHub npm install github:mcler/webpack-concat-plugin:#v4.1.2 or something like that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants