-
-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mouse click accuracy #6117
Comments
doesn't happen to me so I'll need more info (does it happen if you disable scaling? if you use hyprcursor? if you change the cursor size?) |
Nope, with scaling 1 everything works fine. I normally use scaling 2.
It takes me a while to figure out how to do it right. I guess I'll try converting the theme I'm using to hyprcursor format and set the corresponding environment variables.
I've tried two cursor themes (breeze_cursors from KDE and phinger-cursors-light) in two size options: 24 and 32. The issue persists. Oh, one more thing - it looks like the issue is not reproducible inside XWayland apps. |
likely a math error with xcursor hotspots somewhere then |
I have checked and can reproduce this with hyprcursor as well. |
Well, when I change this code (in main) CBox CPointerManager::getCursorBoxGlobal() {
return CBox{pointerPos, currentCursorImage.size / currentCursorImage.scale}.translate(-currentCursorImage.hotspot / currentCursorImage.scale);
} to this one CBox CPointerManager::getCursorBoxGlobal() {
return CBox{pointerPos, currentCursorImage.size / currentCursorImage.scale}.translate(-currentCursorImage.hotspot);
} it fixes the issue. I don't know any shit about how valid this is. |
does it happen if you disable hardware cursors...? |
I see no change in behavior from enabling/disabling hardware cursors. I mean, if I apply the nano-patch above, the issue disappears regardless of the kind of cursors used. |
ok then |
Thank you! In the latest main (553232a3e4c112c8511c8511309e6b685cb614895e714) the issue is still reproducible, but only if hardware cursors are enabled. I don't know why, maybe because of 0d6eae0, which was not present at the time of initial testing. |
bing chilling |
patch.txt |
Nope, still doesn't work with hardware cursors enabled (and works with software cursors on) |
This change fixes the hardware cursors for me (while not breaking the software cursors). Found it tinkering around your patch. |
thanks, can you make a MR? |
Sure. Please take a look. |
Hyprland Version
System/Version info
Bug or Regression?
Bug
Description
When selecting text or clicking on links/buttons, the click is registered a few pixels to the right of the actual cursor position. Similar to old issue #4691, this only seems to happen when the cursor shape is changed.
There is also a strange jump to the right when changing the cursor shape (see video).
This happens starting from commit ed411f5
I'm using xcursor. Enabling or disabling hardware cursors using the WLR_NO_HARDWARE_CURSORS environment variable and/or the cursor:no_hardware_cursors option has no visible effect whatsoever.
How to reproduce
Move the cursor to the boundary of the link.
Crash reports, logs, images, videos
issue.mp4
normal.mp4
The text was updated successfully, but these errors were encountered: