Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popup_during_fullscreen: Expand to allow all new floating windows. #6062

Closed
2 tasks done
orestisfl opened this issue May 19, 2024 · 4 comments · Fixed by #6068
Closed
2 tasks done

popup_during_fullscreen: Expand to allow all new floating windows. #6062

orestisfl opened this issue May 19, 2024 · 4 comments · Fixed by #6068
Assignees
Labels
accepted Has been approved and is ok to start working on enhancement requires-configuration This feature request requires new configuration

Comments

@orestisfl
Copy link
Member

orestisfl commented May 19, 2024

Welcome

  • Yes, I've searched similar issues and discussions on GitHub and didn't find any.

Impact

  • This feature requires new configuration and/or commands

Current Behavior

popup_during_fullscreen depends on the WM_TRANSIENT_FOR property both for smart and leave_fullscreen.

Desired Behavior

Extend popup_during_fullscreen to allow all floating-by-default windows since those are often notifications, popups or helper windows that the user doesn't want to miss. These for various reasons might not have the WM_TRANSIENT_FOR property. For example, if an application different than the focused one is showing the popup or the focused application might not set the hints because it might not be complying with that part of the standard or it might be using some external tool like zenity to show dialogs.

Related Issues

CC @stapelberg thoughts?

i3 version

i3 version 4.23-35-gcaf5b32d © 2009 Michael Stapelberg and contributors
@i3bot
Copy link

i3bot commented May 19, 2024

Please note that new features which require additional configuration will usually not be considered. We are happy with the feature set of i3 and want to focus in fixing bugs instead. We do accept feature requests, however, and will evaluate whether the added benefit (clearly) outweighs the complexity it adds to i3.

Keep in mind that i3 provides a powerful way to interact with it through its IPC interface: https://i3wm.org/docs/ipc.html.

@i3bot i3bot added the requires-configuration This feature request requires new configuration label May 19, 2024
@orestisfl orestisfl self-assigned this May 19, 2024
@stapelberg
Copy link
Member

Will this be an opt-in change, or are you suggesting to change the existing behavior without a way to opt-out? I’m a bit worried that people will realize they are dependent on the current behavior for some use-case.

@orestisfl
Copy link
Member Author

Will this be an opt-in change, or are you suggesting to change the existing behavior without a way to opt-out? I’m a bit worried that people will realize they are dependent on the current behavior for some use-case.

Yes, I am suggesting it as a new option, e.g. popup_during_fullscreen all

@stapelberg
Copy link
Member

Sounds good

@orestisfl orestisfl added the accepted Has been approved and is ok to start working on label May 20, 2024
orestisfl added a commit that referenced this issue May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Has been approved and is ok to start working on enhancement requires-configuration This feature request requires new configuration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants