Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Non Op/Permission people can run some commands #23

Open
Flemmli97 opened this issue Jan 9, 2020 · 1 comment
Open

[Bug] Non Op/Permission people can run some commands #23

Flemmli97 opened this issue Jan 9, 2020 · 1 comment
Assignees
@iGoodie
Labels
bug

Comments

@Flemmli97
Copy link

Flemmli97 commented Jan 9, 2020 •
edited

Describe the bug
Non op and permission people can run commands like /twitchspawn test <> and [...] execute, which they shouldnt be able to. ModuleTest and ModuleExecute are missing permission checks

To Reproduce
Create server and have non op and non permission people (Credentials.toml) on and let them run the command.

Version (please complete the following information):

  • TwitchSpawn Version: 0.4.17
  • Forge Version: 1.12.2-14.23.5.2847
@Flemmli97 Flemmli97 added the bug label Jan 9, 2020
@Flemmli97 Flemmli97 changed the title Non Op/Permission people can run several commands Non Op/Permission people can run some commands Jan 9, 2020
@iGoodie iGoodie changed the title Non Op/Permission people can run some commands [Bug] Non Op/Permission people can run some commands Jan 9, 2020
@iGoodie iGoodie self-assigned this Jan 9, 2020
@iGoodie
Copy link
Owner

iGoodie commented Jan 9, 2020

Oh I knew I should've created a hook for the permissions check! I always end up forgetting about the permission check.. Thanks once again for revealing another defect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iGoodie iGoodie

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iGoodie @Flemmli97