You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This looks like it needs wider checking than the PR as it also affects getMouseRight and we need to ensure parity with windows. There might be some discussion to be had about what should happen for mouseups for instance (as this is a possible mechanism for a dev to differentiate left/right mouse ups. It would also be a little bit of detective work to figure out what was happening before I made the restructure that introduced these methods.
The PR looks like a sensible proposition as a starting point, but we need to ensure consistency. (As a more minor matter, PRs that match formatting are easier to merge directly and in this case the opening curly bracket has been moved on the method)
This issue relates to #635 and they should be resolved together
Issue Description
The
getMouseLeft
function inIGraphicsMac_view.mm
incorrectly sets the left mouse button state to alwaystrue
, regardless of its actual state.Expected Behavior
The function should accurately reflect the real state of the left mouse button.
Observed Behavior
Regardless of the actual mouse state,
info.ms.L
is set totrue
.Proposed Fix
Modify the function to assess the
NSEvent
type to determine the left mouse button's state.Suggested Change
The text was updated successfully, but these errors were encountered: