Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Ink example isn't useful #11

Open
humazed opened this issue Jan 4, 2020 · 1 comment
Open

The Ink example isn't useful #11

humazed opened this issue Jan 4, 2020 · 1 comment
Labels
Revision Needed Edit existing code

Comments

@humazed
Copy link

humazed commented Jan 4, 2020

In your example when you remove the ink it still has the same behavior.

a better example would be the one from the docs

Material(
  color: Colors.teal[900],
  child: Center(
    child: Ink(
      color: Colors.yellow,
      width: 200.0,
      height: 100.0,
      child: InkWell(
        onTap: () { /* ... */ },
        child: Center(
          child: Text('YELLOW'),
        )
      ),
    ),
  ),
)
``

vs 

Material(
color: Colors.teal[900],
child: Center(
child: Container(
color: Colors.yellow,
width: 200.0,
height: 100.0,
child: InkWell(
onTap: () { /* ... */ },
child: Center(
child: Text('YELLOW'),
)
),
),
),
)


and the image example.
@ibhavikmakwana ibhavikmakwana added the Revision Needed Edit existing code label Jan 24, 2020
@ibhavikmakwana
Copy link
Owner

Hello,
Sorry for the delayed response.
I will look into it and update the repository accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Revision Needed Edit existing code
Projects
None yet
Development

No branches or pull requests

2 participants