-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReplayGain support #4915
Comments
Really nice writeup of the requested feature. The request is to add UI support for the
I'm assuming it is desirable to also include support for the associated options: |
This commit will: - Add new the settings replayGain, replayGainPreamp, replayGainClip and replayGainFallback to the Preferences class - Add support for the new settings to the mpvInit method in the MPVController class - Add a ReplayGain section to the Video/Audio tab of IINA's settings These changes allow the user to control mpv's support for ReplayGain tags.
Please have a look at the screenshots of the proposed implementation in PR #4932. Does that look like what you were expecting? Does the |
This is brilliant - looks great! Yup, looks like its working fine. Thank you again |
Very helpful that you entered this issue. I was unaware of this I'm a junior IINA developer so the proposed changes still need to be reviewed by the other developers. Future release plans are always subject to change, but last I heard the next release will be a bug fix release, so unlikely this change will make it into that release. As soon as possible after that release will be the first beta release for the long planned feature release. I'm expecting this change will make it into that release. |
Thanks low-batt; sounds good! and thanks again |
This commit will: - Add new the settings replayGain, replayGainPreamp, replayGainClip and replayGainFallback to the Preferences class - Add support for the new settings to the mpvInit method in the MPVController class - Add a ReplayGain section to the Video/Audio tab of IINA's settings These changes allow the user to control mpv's support for ReplayGain tags.
This commit will: - Add new the settings replayGain, replayGainPreamp, replayGainClip and replayGainFallback to the Preferences class - Add support for the new settings to the mpvInit method in the MPVController class - Add a ReplayGain section to the Video/Audio tab of IINA's settings These changes allow the user to control mpv's support for ReplayGain tags.
What you want IINA to do:
Would be great to be able to add ReplayGain support natively to the UI (I know we can set values using MPV advanced settings but it would be nice to be able to set and alter ReplayGain settings in the audio settings).
Why you think this should be added:
It would allow libraries of music which have ReplayGain tags added to music files to be able to be played at the intended gain levels.
Examples of other projects that have something similar:
Foobar2000 Mac has an excellent ReplayGain implementation, with clipping support etc. Note, I'm not suggesting Iina supports creation of ReplayGain tags, only reading and using existing tags.
The text was updated successfully, but these errors were encountered: