-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FFmpeg/lavfi=[unsharp filter] does not work with yuv420p10 Pixel Format #4930
Comments
It is desirable to capture evidence of what is going wrong before attempting to fix the problem by clearing settings. IINA stores settings using the macOS defaults system. Settings can be accessed using the defaults command in Terminal. Open Terminal and run this command: defaults read com.colliderli.iina savedVideoFilters And this command: defaults read com.colliderli.iina savedAudioFilters Capture the output and post it here. This is what it looks like when I run these commands: Video filters:
Audio filters:
Before attempting to clear the problem it would be good to collect log files, especially the
Once IINA has restarted, reproduce the problem. Then:
The The log files can also be accessed using Terminal as shown here: low-batt@gag com.colliderli.iina$ pwd
/Users/low-batt/Library/Logs/com.colliderli.iina
low-batt@gag com.colliderli.iina$ ls
2022-10-04-17-57-15_jVrbWy
low-batt@gag com.colliderli.iina$ cd 2022-10-04-17-57-15_jVrbWy
low-batt@gag 2022-10-04-17-57-15_jVrbWy$ ls
iina.log mpv.log
low-batt@gag 2022-10-04-17-57-15_jVrbWy$ With logging enabled IINA creates a new log directory each time it is started. If accessing the logs using DO NOT FORGET to disable logging once you have obtained log files for the problem being investigated. IINA does not restrict the size of log files or delete old logs. If you leave logging enabled the logs will continue to accumulate. Saved filters can be cleared by deleting the assocated setting: defaults delete com.colliderli.iina savedVideoFilters As we don't know what is going wrong, I can't say if that will fix the problem. Attempting to add a A value of
I believe that option merely provides an easy way of adding a FFmpeg unsharp filter. |
Another place filter setting are retained is in the Watch Later file for the video being played. This With that setting enabled, I played a file, applied a filter and quit IINA before reaching the end of the video. I then checked what option values were saved: low-batt@gag ~$ md5 -qs '/Users/low-batt/Movies/big_buck_bunny.mp4' | xargs -I % cat ~/Library/Application\ Support/com.colliderli.iina/watch_later/%
start=3.350000
pause=yes
volume=42.000000
vf=format=convert=no:colorlevels=full:colormatrix=auto:primaries=auto
low-batt@gag ~$ You can see the video filter ( The easiest way to clear such files is to disable the |
Thank you for answering, Found the cause, it's the Pixel Format and might be the inbuilt FFmpeg version yuv420p10 this one ignores sharpening (I have several different files with this code all of them ignores sharpening) yuv420p this one is ok 2 workarounds
to convert the same file with either ffmpeg -i in_file -filter:v "format=yuv420p" out_file But it's a realtime process per file, so not really helpful
to add a custom FFmpeg filter Name: result: you need to activate the "pixels" first and only then any FFmpeg filter affected by Pixel Format so a temp solution is above |
IINA v. 1.3.4
Probably because of adding several Unsharp filters to the SavedFilters, clearing the saved list did not help
tried v. 1.3.3, same, used default settings , nothing, blur (negative values) also do not work
The filter worked "yesterday", nothing changed (except the changes in the savedVideofilters),
same video file, HW off.
Removing all saved filters did not help.
And the interesting part is, The filter works on the background (when activated) but does not affect picture at all. How do I know?
If I apply several unsharp filters at once it gets very laggy. But the picture stays unaffected. HW off/auto does not matter.
So when they work correctly all the filters apply together and the video output gets even more affected.
But now unsharp/blur does not affect the picture at all, no matter what value
Flip/Negative filters still work fine.
At this moment I had to use MPV filters from (advanced settings) to activate Sharpen filter, it works (but it always active)
I cannot add the same filter from the Video Filters setting / Custom (MPV). It does not accept the settings.
e.g.
filter name:
Sharpen
value:
4
Is where any way to clear the DB\Settings? Clean re-install?
The text was updated successfully, but these errors were encountered: