-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Directory not found (path too long; Windows) #14
Comments
Are there any courses that actually exceed this limit?
It's already using the course url to download. Or am I misunderstanding?
What is the purpose of this? |
For example, I have one that looks like Building an Enterprise Grade Distributed Online Analytics Platform\4 Introducing Distributed Computation with Apache Storm\6 Demo - Downloading, Configuring, and Running Apache Storm.mp4
I meant building-enterprise-distributed-online-analytics-platform in https://app.pluralsight.com/library/courses/building-enterprise-distributed-online-analytics-platform
Just move the issue of the script crashing on Windows with a non-explicit error to the hand of the user. We allow the user to download videos even if the file system could prevent it in the first place. Then if the user want to rename them (because they will be named as GUID), the "mapping file" will allow them to know the original title and the Windows Explorer will prevent the user to have a >= 260 path characters. |
What a ridiculous limitation :/ How does wget do it? |
Yep... Welcome to 2020 Windows!
I didn't use wget since a while but it is likely to be the same way as everyone else; Use the Content-Disposition HTTP header response or the "filename" part from the URL request. (The value next to the last / (slash) but before GET/# anchor). If you use one of the cdn file from the |
I meant to ask how it deals with filenames longer than 50 characters
|
I was talking about the "Current Working Directory" (CWD) that should be less than 50 characters just as a kind of warning that you may look for trouble otherwise. Like if you try to download/run your script from The actual path on drive is: How wget deal with that... oh by not working and returning the error I saw (DirectoryNotFoundException in C#): EDIT: Reformulating everything because I suck |
Makes sense. I’m somewhat leaning towards keeping it as is and letting it fail. I don’t know how I feel about babysitting bad configuration options. But if we do fix it, I think we could just truncate the folders and filenames such that it doenst go over the limit. I only need 6 characters for each filename. Rest can be chopped off as needed. I really want to keep it simple, I don’t want to see half the codebase to be workarounds for the operating system. |
This comment has been minimized.
This comment has been minimized.
Whence the simple >=50 characters kind of validation. A kind of 2 line codes at the beginning. Thought could also try to add a catch(DirectoryNotFound) for Windows as well to write a warning. BTW Does Linux trim the directory name? I got one case where the title of the course end with a space. When doing the Directory.Create (c#) Windows trimmed the directory name so the File.Create failed because it didn't match, |
^ Don't Google this tool, look suspicious. User reported, let see where it go |
Titles could be huge and Windows still limit the path to 260 characters (there is an option in Windows 10 to increase it but you have to opt-in... by editing the register...)
I recommend the CWD to be <= 50 characters.
As for future modification/parameters:
The text was updated successfully, but these errors were encountered: