Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashing on options in the reserved space #62

Open
SibertDekimo opened this issue Mar 4, 2020 · 0 comments
Open

Crashing on options in the reserved space #62

SibertDekimo opened this issue Mar 4, 2020 · 0 comments

Comments

@SibertDekimo
Copy link

The DHCP crashes when a DCHP-request is sent with options in the 224-254 range.
According to iana, this space is reserved for private use. Microsoft happens to use this range (249 for classless static route), which makes the DHCP-server incompatible with my OS, Windows 10.

I have fixed this by editing line 206 in dhcp.js:
this.emit('error', 'Unknown option ' + req);

becomes

if(!(req >= 224 && req <= 255))
{
	this.emit('error', 'Unknown option ' + req);
}

I don't know if this is the correct/best solution, but it works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant