Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work if the password contains special characters for webdavs use. #10292

Open
kismetro opened this issue Feb 8, 2024 · 0 comments
Open
Labels
fs: webdav Related to the Webdav filesystem

Comments

@kismetro
Copy link

kismetro commented Feb 8, 2024

Bug Report

Description

Does not work if the password contains special characters for webdavs use.
When using WebDAV, if your password contains an exclamation mark (“!”), it works fine.
However, when there’s an “@” symbol in the password, it doesn’t function properly. �
I’ve also confirmed that login fails when certain special characters are included in the password.

When using “ask_password = true”, it works by prompting the user to input the password each time.
However, when adding the password directly to the config.local file as “password = xxxx!@”, automatic login fails, preventing actions like Push from functioning properly.

Reproduce

  1. webdav + https + id/password(with special characters such as "@")
  2. config 설정
    [core]
    remote = xxxx
    autostage = true
    ['remote "xxxx"']
    url = webdavs://xxxx/mlartifacts/dvc-test
    user = user
    ask_password = false
  3. config.local 설정
    ['remote "xxxx"']
    password = xxxx!@#
    or
    password = xxxx!@#
    or
    password = xxxx%21%40%23
    and
    others
  4. erros dvc push
    ERROR: unexpected error - received 401 (Unauthorized): Client error '401 Unauthorized' for url

but.
after changing password with only such as xxxx!. Also config.local is set "password = xxxx!", then it works well.

Expected

['remote "xxxx"']
password = xxxx!@#
or
password = "xxxx!@#"
or
other solutions

Environment information

Output of dvc doctor:

$ dvc doctor
DVC version: 3.43.1 (pip)
-------------------------
Platform: Python 3.10.13 on Linux-5.4.0-170-generic-x86_64-with-glibc2.31
Subprojects:
        dvc_data = 3.9.0
        dvc_objects = 3.0.6
        dvc_render = 1.0.1
        dvc_task = 0.3.0
        scmrepo = 2.1.1
Supports:
        http (aiohttp = 3.9.3, aiohttp-retry = 2.8.3),
        https (aiohttp = 3.9.3, aiohttp-retry = 2.8.3),
        webdav (webdav4 = 0.9.8),
        webdavs (webdav4 = 0.9.8)
Config:
        Global: /root/.config/dvc
        System: /etc/xdg/dvc
Cache types: hardlink, symlink
Cache directory: ext4 on /dev/mapper/ubuntu--vg-ubuntu--lv
Caches: local
Remotes: webdavs
Workspace directory: ext4 on /dev/mapper/ubuntu--vg-ubuntu--lv
Repo: dvc, git

Additional Information (if any):

@efiop efiop added the fs: webdav Related to the Webdav filesystem label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs: webdav Related to the Webdav filesystem
Projects
None yet
Development

No branches or pull requests

2 participants