Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Highlighting with Custom Bold Text Color in Minimal Theme #697

Open
WoodyGaston opened this issue Feb 16, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@WoodyGaston
Copy link

WoodyGaston commented Feb 16, 2024

I've encountered an issue with the Minimal theme in Obsidian where custom colors for bold text do not behave as expected when highlighted. Specifically, when highlighting text that is already bold, the custom bold text color reverts to white instead of maintaining the specified color. However, this issue does not occur when highlighting is applied outside of bold text, where the custom color is correctly preserved.

I am currently using a CSS snippet provided by @._river on Discord to address this issue. The snippet ensures that both highlighted bold text and bold text within highlighted sections retain the custom bold color and weight. Here's the CSS code:

.markdown-rendered :is(strong, b) mark,
.markdown-rendered mark :is(strong, b),
.cm-s-obsidian .cm-highlight.cm-strong {
    font-weight: var(--bold-weight);
    color: var(--bold-color);
}

Suggested Solution:
It would be greatly appreciated if the Minimal theme could be updated to natively support this behavior, eliminating the need for custom snippets.

Thank you for considering this feature request, and congrats for all the work already done.

image
image

@WoodyGaston WoodyGaston added the enhancement New feature or request label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant