Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluding context in mappings breaks reindexing #411

Open
simonpoole opened this issue Apr 15, 2019 · 3 comments
Open

Excluding context in mappings breaks reindexing #411

simonpoole opened this issue Apr 15, 2019 · 3 comments

Comments

@simonpoole
Copy link
Contributor

In mappings.json we exclude the context fields from the stored source document

"_source": {
    "excludes": [
        "context.*"
    ]
},

As the context fields are populated by the importer and updater, this implies that we can't reindex in situ (aka any change in the mappings or similar requires a reimport). I can see the space savings in doing this, but on the other hand it means that we can't evolve the mappings and related aspects of Photon in a "user"-friendly fashion.

@lonvia
Copy link
Collaborator

lonvia commented Apr 15, 2019

I would guess that the majority of users downloads the precomputed database provided by Graphhopper and rather repeat the download than reindexing the database. So I'd consider size a much more important argument.

@simonpoole
Copy link
Contributor Author

That is true now given that the choice isn't actually available, but given a lightweight way to update, I suspect that will change essentially immediately.

@lonvia
Copy link
Collaborator

lonvia commented Apr 15, 2019

I still doubt that the average user will do that. If you want to provide a development mode with a reindexable database, now that would be a different story.

Please also note the discussion in #291.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants