Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): 支持自定义加载动画 #1893

Merged
merged 6 commits into from May 19, 2024

Conversation

Sight-wcg
Copy link
Collaborator

@Sight-wcg Sight-wcg commented May 12, 2024

😃 本次 PR 的变化性质

请至少勾选一项

  • 功能新增
  • 问题修复
  • 功能优化
  • 分支合并
  • 其他改动:请在此处填写

🌱 本次 PR 的变化内容

已在 IE8+ 仿真中测试通过
https://stackblitz.com/edit/vu45xk?file=index.html

✅ 本次 PR 的满足条件

请在申请合并之前,将符合条件的每一项进行勾选

  • 已提供在线演示地址(如:codepen, stackblitz)或无需演示
  • 已对每一项的改动均测试通过
  • 已提供具体的变化内容说明

Copy link

stackblitz bot commented May 12, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sentsim
Copy link
Member

sentsim commented May 13, 2024

赞!

@Sight-wcg Sight-wcg marked this pull request as draft May 13, 2024 22:01
@Sight-wcg Sight-wcg marked this pull request as ready for review May 15, 2024 22:33
@sentsim
Copy link
Member

sentsim commented May 17, 2024

@Sight-wcg 晨星认为是否可以把 loadingTemplet 选项合并到已有的 loading 选项中,让其支持两种类型:

  • 若为 boolean 类型,即采用默认的加载风格。
  • 若为 string 类型,即采用自定义的加载动画模板。

如此也可避免 loadingTempletloading 的耦合或依赖。

@Sight-wcg
Copy link
Collaborator Author

@Sight-wcg 晨星认为是否可以把 loadingTemplet 选项合并到已有的 loading 选项中,让其支持两种类型:

  • 若为 boolean 类型,即采用默认的加载风格。
  • 若为 string 类型,即采用自定义的加载动画模板。

如此也可避免 loadingTempletloading 的耦合或依赖。

应该可以,已修改

@sentsim sentsim merged commit ca56d0b into layui:main May 19, 2024
@Sight-wcg Sight-wcg deleted the feat/tabl-loading-tpl branch May 20, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants