Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong UDP Checksum when using IP Fragmentation #106

Open
alorbach opened this issue Apr 23, 2020 · 3 comments
Open

Wrong UDP Checksum when using IP Fragmentation #106

alorbach opened this issue Apr 23, 2020 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@alorbach
Copy link

alorbach commented Apr 23, 2020

I am working on https://github.com/rsyslog/rsyslog/blob/master/plugins/omudpspoof/omudpspoof.c and trying to fix a problem with IP Fragmentation. The project is using libnet to build IP/UDP Packages and sending syslog data.

The problem is, that if we try to fragment packages, the UDP Checksum is not correctly calculated if we set the correct UDP Packet length here: https://github.com/rsyslog/rsyslog/blob/master/plugins/omudpspoof/omudpspoof.c#L422

And If I am using the IP Packet length, the UDP Packet is truncated.

So I am looking for a solution to do propper IP fragementation with UDP Packages, thanks for help.

@alorbach
Copy link
Author

I have workaround the issue by disabling checksum calculation for the UDP Header for now with:
libnet_toggle_checksum

I guess there are some library changes needed in order to generated a corrrect UDP Checksum if you do IP fragmentation on your own.

@alorbach alorbach reopened this Apr 24, 2020
@sam-github
Copy link
Collaborator

Perhaps you have the time and interest to work on this feature @alorbach ?

@troglobit
Copy link
Collaborator

Any suggestions you have, API ideas: naming, pseudo code, etc. are welcome, @alorbach :)

@troglobit troglobit added bug Something isn't working help wanted Extra attention is needed labels May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Development

No branches or pull requests

3 participants