-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To downgrade the warning messages related to no DeviceInterfaceGUID registered
to info - to debug
#1394
Comments
no DeviceInterfaceGUID registered
to info
The warning comes from PR #1322 |
It is now demoted to "info". However, for xusb, I think it sets debug level to "info" by default. So do these messages still show up there? |
Yes it will show up. I think we can live with this for now.
|
Maybe it should be an info for some devices and ignored for others, I dunno. Maybe @pazourek who added the warning or @sonatique would know. |
I have a vaguely bad feeling about this, could be the next potential supply chain poisoning similar to xz-utils? |
Re-open this issue. |
Perhaps a compilation parameter can be defined to control whether debugging information is output? |
It is already there. |
@pazourek @sonatique |
so, the default behavior is enable all debug information output? |
If I want to turn off all debugging output by default, what do I do at compile time? Any reference examples? |
The default should be
But you change to use
|
thank you for your reply, I will handle it right now. |
Well done, thank you again for your assistance! |
The libusb 1.0.26 did not contain this warning. This warning is useless for many devices, but it gives us an important information related to composite devices on MS Win platform. Without the GUIDs, the libusb is not able to access individual interfaces of the composite device. It would probably make sense to report this warning only for composite devices. But I am not sure if it is possible to simply detect whether the current interface belongs to the composite device during listing the device interfaces. |
I vote for keeping this warning message in the code. I would be fine with downgrading this warning message to debug level. Since the previous release did not show this warning at all, it was hard to find what is going on and why the composite device does not work for me. |
Yes, if we cannot limit the message to composite devices, or until we can, we should demote it to debug level. It seems it can be too verbose as of the example linked above, and if something doesn't work it is natural to enable debug logging anyway. |
I agree. |
no DeviceInterfaceGUID registered
to infono DeviceInterfaceGUID registered
to info - to debug
I made it a debug message. |
From here by me.
Just wondering if we can downgrade the warning messages related to
no DeviceInterfaceGUID registered
to info.The text was updated successfully, but these errors were encountered: