Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for Linux installation are out of date #458

Open
holyoaks opened this issue Dec 19, 2022 · 6 comments
Open

Docs for Linux installation are out of date #458

holyoaks opened this issue Dec 19, 2022 · 6 comments

Comments

@holyoaks
Copy link

So I had fun installing the agent in a new Linux install. This page, https://github.com/logdna/logdna-agent-v2/#installing-on-linux, has a section

Installing on Linux

Refer to the documentation for [deploying the agent on Linux](https://github.com/logdna/logdna-agent-v2/blob/master/docs/LINUX.md).

Following the link there, specifically the configure the agent section (https://github.com/logdna/logdna-agent-v2/blob/master/docs/LINUX.md#configure-the-agent), I arrived at a section that is out of date. Those steps, specifically writing etc/logdna.env and setting the environment variables inside that file as specified in step 2 did not work.

What did work is following the steps in the Configuration section of the first page (https://github.com/logdna/logdna-agent-v2/#configuration) and setting up a yaml configuration file.

Please update the documentation to prevent others from wasting time trying outdated approaches to configuring the agent. Thanks!

@dkhokhlov
Copy link
Contributor

dkhokhlov commented Jan 5, 2023

etc/logdna.env is specified in logdna-agent systemd service config.
does your linux uses systemd?

@holyoaks
Copy link
Author

holyoaks commented Jan 5, 2023

We do not use systemd on our systems, but the problem is that the docs specifically say to follow the instructions for installation on Linux, but that's not necessarily the correct approach. It wasn't until I read the Configuration section that I tried the approach of the yaml file and found that to work.

@dkhokhlov
Copy link
Contributor

dkhokhlov commented Jan 5, 2023

The doc does say that agent is using systemd. https://github.com/logdna/logdna-agent-v2/blob/master/docs/LINUX.md#usage. And all steps are done in that context.

@holyoaks
Copy link
Author

holyoaks commented Jan 5, 2023

I understand that, but if you don't read the entire docs, and are coming from the link provided in my original submission, it's not clear that you should use the yaml based approach if you're not using systemd. Basically, the options to configure the agent for Linux are spread across two pages, and there's not a clear explanation of `Use .env if you're using systemd, and if you're not, try using the yaml file). Your users shouldn't have to read the entire documentation simply to configure the agent; it should be clear what approach is recommended depending on the user's situation.

@jiangao1
Copy link

jiangao1 commented Jan 5, 2023

@holyoaks Thanks for your feedback! We'll bring this feedback to our team and hopefully make the instruction more clear to users, so that one doesn't have to jump between multiple pages. We do have some initiative this year making the documentation better across the board. I'll create an internal JIRA to keep track.

@holyoaks
Copy link
Author

holyoaks commented Jan 5, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants