Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The editor looks good, but it works in a wrong way. #22

Open
imsuperip opened this issue Apr 23, 2022 · 5 comments
Open

The editor looks good, but it works in a wrong way. #22

imsuperip opened this issue Apr 23, 2022 · 5 comments

Comments

@imsuperip
Copy link

At least Conditional Abort and Timer are bad which are essential in behaviour tree development.

@luis-l
Copy link
Owner

luis-l commented Jun 20, 2022

Hey. Feel free to list feedback and potential improvements. I would appreciate it.

@WeslomPo
Copy link

WeslomPo commented Aug 29, 2022

I think this is a problem that previus author talked about.
If we arrange conditions like that:
image
We expect it will execute task Print when all conditions are true (as we can see there are all conditions are the same).
If we format it like that, it will work just fine:
image

So, there are a problem in iterator, that will return failure if condition does not have any leafs. This is strange to me, I thought that BT work great as on first picture.

Now I thinking about why is this work that way? If this is an error I need to fix that for me, or is it intentional, and i'am just bad at BT :)

@WeslomPo
Copy link

After podering some time, I fixed that by testing conditionalResult in ConditionalAbort if there no children nodes like that:
image
_conditionalResult must be initialized by called Condition(); in OnStart and Evaluate methods.

Idk this is intentional behaviour, or error. But I feel this is more appropriate working than before.

@luis-l
Copy link
Owner

luis-l commented Oct 23, 2022

Hello @WeslomPo If you have a fix, could you create a PR? I would be happy to merge it. I really appreciate it!

@luis-l
Copy link
Owner

luis-l commented Oct 23, 2022

To give a bit more context, yes, conditional aborts returned failure if they did not have any children.

It would make more sense if they could work "childless" and just return their evaluated condition result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants