Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mention how to import spec files in CONTRIBUTING.md #104

Open
trusktr opened this issue Dec 14, 2020 · 2 comments
Open

mention how to import spec files in CONTRIBUTING.md #104

trusktr opened this issue Dec 14, 2020 · 2 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@trusktr
Copy link
Member

trusktr commented Dec 14, 2020

Need to add a blurb about the test entry points and all spec files being imported.

@trusktr trusktr added this to To do in Initial Port via automation Dec 14, 2020
@trusktr trusktr added the good first issue Good for newcomers label Dec 14, 2020
@StEvUgnIn
Copy link
Contributor

You can assign me this one. But I need more information than to just 'import'. Do you mean how to write proper tests in Typescript?

@trusktr
Copy link
Member Author

trusktr commented Jan 30, 2021

@StEvUgnIn Hello! What I meant was, that currently the spec files are imported, starting with src/as/index.spec.as. If we forget to import a spec file, it will be skipped from tests.

Did it this way because it is way faster (as-pect will make a single Wasm module). The other way is to avoid import altogether and put a file matching pattern in as-pect.config.js so that it picks all the files up, then compiles each one as its own entry point (about 300% slower).

@p3nGu1nZz p3nGu1nZz self-assigned this Feb 23, 2021
@p3nGu1nZz p3nGu1nZz moved this from To do to In progress in Initial Port Feb 23, 2021
@p3nGu1nZz p3nGu1nZz moved this from In progress to Testing in Initial Port Feb 23, 2021
@p3nGu1nZz p3nGu1nZz moved this from Testing to In progress in Initial Port Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Initial Port
  
In progress
Development

No branches or pull requests

3 participants