Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Patch] man/lxterminal.xml: description of -t and --title is wrong. Add description for help and version. #97

Open
ZjYwMj opened this issue Jun 13, 2021 · 3 comments

Comments

@ZjYwMj
Copy link

ZjYwMj commented Jun 13, 2021

For

$ lxterminal -v
lxterminal 0.4.0

The following patch

  1. Fixes descriptions of -t and --title in the manual page. Compare it with lxterminal -h.
  2. Add entries for the help and version options.
--- a/man/lxterminal.xml	2021-06-13 17:27:50.173982416 +0000
+++ b/man/lxterminal.xml	2021-06-13 17:27:08.264651478 +0000
@@ -55,17 +55,24 @@
 	<listitem>	  <para>Set the terminal's size in characters and lines.</para>
 	</listitem>
       </varlistentry>
+      <varlistentry>	<term>	  <option>-h</option>
+	  <option>--help</option>
+	</term>fixes
+	<listitem>	  <para>Prints a short help message, and exit.</para>
+	</listitem>
+      </varlistentry>
       <varlistentry>	<term>	  <option>-l</option>
 	  <option>--loginshell</option>
 	</term>
 	<listitem>	  <para>Executes login shell.</para>
 	</listitem>
       </varlistentry>
-      <varlistentry>	<term>	  <option>-t <replaceable>NAME[,NAME[,NAME[...]]]</replaceable></option>
-	  <option>--title=<replaceable>NAME[,NAME[,NAME[...]]]</replaceable></option>
+      <varlistentry>	<term>	  <option>-T <replaceable>NAME</replaceable></option>
+	  <option>-t <replaceable>NAME</replaceable></option>
+	  <option>--title=<replaceable>NAME</replaceable></option>
+ 	  <option>--tabs=<replaceable>NAME,NAME[,NAME[...]]</replaceable></option>
 	</term>
-	<listitem>	  <para>Set the terminal's title. Use comma for multiple tabs.</para>
+	<listitem>	  <para>Set the terminal's title. Comma separated multiple titles create multiple tabs only with the <option>--tabs=</option> form.</para>
 	</listitem>
       </varlistentry>
       <varlistentry>        <term>          <option>--working-directory=<replaceable>DIRECTORY</replaceable></option>
@@ -73,6 +80,12 @@
         <listitem>          <para>Set the terminal's working directory.</para>
         </listitem>
       </varlistentry>
+      <varlistentry>	<term>	  <option>-v</option>
+	  <option>--version</option>
+	</term>
+	<listitem>	  <para>Prints version information, and exit.</para>
+	</listitem>
+      </varlistentry>
     </variablelist>
   </refsect1>
 
@ZjYwMj ZjYwMj changed the title [Patch] lxterminal.xml: -t and --title are wrong. Add description for help and version. [Patch] lxterminal.xml: description of -t and --title are wrong. Add description for help and version. Jun 14, 2021
@ZjYwMj ZjYwMj changed the title [Patch] lxterminal.xml: description of -t and --title are wrong. Add description for help and version. [Patch] man/lxterminal.xml: description of -t and --title are wrong. Add description for help and version. Jun 14, 2021
@ZjYwMj ZjYwMj changed the title [Patch] man/lxterminal.xml: description of -t and --title are wrong. Add description for help and version. [Patch] man/lxterminal.xml: description of -t and --title is wrong. Add description for help and version. Jun 14, 2021
@FinboySlick
Copy link
Contributor

Thank you. Would you like to add this as a pull request to maintain credit?

@ZjYwMj
Copy link
Author

ZjYwMj commented Jun 15, 2021

As far as I can tell, I have right now added it as a pull request.

@ZjYwMj
Copy link
Author

ZjYwMj commented Jun 17, 2021

I have modified the patch some few minutes ago. Actually, It is probably better if I will update my lxterminal repository. I will get to that now. I will explain what I did at the comment in my lxterminal repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants