Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with high DPI scaling #1058

Closed
Yournished opened this issue Jun 1, 2019 · 5 comments
Closed

Issue with high DPI scaling #1058

Yournished opened this issue Jun 1, 2019 · 5 comments
Labels
🦞 resolved/duplicate This issue or pull request already exists

Comments

@Yournished
Copy link

I have a high DPI screen so I use DPI scaling. Header font is way too large for my screen - the top level header takes up 1/10th of my vertical space! Adjusting font size only changes the body text.

I'd like to add a compact theme that has smaller headers. Where are the theme CSS files? I'm using the flatpak on Linux.

@fxha
Copy link
Contributor

fxha commented Jun 2, 2019

Currently there is no option to edit the theme without rebuilding Mark Text. I think #1029 may help with this issue. Could you please upload an image from Mark Text with some text?

@fxha
Copy link
Contributor

fxha commented Jun 7, 2019

Closing this issue as no further information has been provided.

@fxha fxha closed this as completed Jun 7, 2019
@Yournished
Copy link
Author

@fxha Please reopen issue.

Currently there is no option to edit the theme without rebuilding Mark Text. I think #1029 may help with this issue.

That issue is about adding zoom. The zoom is not the problem. Body text size is fine. Header is too big. If I zoomed out, now the body text would be too small. The problem is that the ratio of header text/body text size is too large.

Could you please upload an image from Mark Text with some text?

headers

Closing this issue as no further information has been provided.

For real? You only waited 4 days, dude.

@Jocs Jocs reopened this Jun 13, 2019
@fxha fxha changed the title How to add themes? Issue with high DPI scaling Jun 13, 2019
@Yournished
Copy link
Author

The renaming is wrong. The issue is that more control is needed over theming. The problem with DPI scaling is only a particularly egregious special case of this problem. If you merely add some DPI scaling option, this would still leave other symptoms of hardcoded theming - such as inability to alter contrast, colors or font. Really, the ability to have custom themes has been a standard feature of most GUI programs for several decades now, I feel silly having to explain the necessity for it. The correct solution is to allow users to specify their own themes.

@fxha
Copy link
Contributor

fxha commented Jun 14, 2019

Currently there is no option to edit the theme without rebuilding Mark Text.

Please see my first comment. I guess v0.16.0 should become user themes but I don't know @Jocs planing there. Mark Text is still in active development and I would considered it as alpha software. Our priority is to fix bug and improve the overall experience. Meaning custom themes or other feature may or are less important than other things, especially when we have no stable APIs nor stable GUI elements or CSS paths. This means that we'll add user themes some day but today is not that day and even then themes may be broken after updates before v1.0.0.

If I understood your reply correctly, DPI scaling is not an issue/not the topic of this issue and then is this issue a duplicate of #174 and can be closed, right? If you like, you can subscribe there for further updates.

@fxha fxha added the 🦞 resolved/duplicate This issue or pull request already exists label Jun 14, 2019
@fxha fxha closed this as completed Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦞 resolved/duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants