Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus find-in-folder search box; unfocus with ESC #2294

Open
Henry78 opened this issue Jul 29, 2020 · 1 comment · May be fixed by #3421
Open

Focus find-in-folder search box; unfocus with ESC #2294

Henry78 opened this issue Jul 29, 2020 · 1 comment · May be fixed by #3421

Comments

@Henry78
Copy link

Henry78 commented Jul 29, 2020

When firing CmdOrCtrl+Shift+F the find-in-folder search box is shown in the sidebar, it is even prefilled with highlighted text, but it isn't focused.

This issue requests that the search box gets focussed after the shorcut is fired and is unfocussed if Escape is pressed, then the program should return to the state before the shorcut was fired.

This was also requested in #1311 and #1729
@Henry78 Henry78 mentioned this issue Jul 29, 2020
Closed
1 task
@Ziflin
Copy link

Ziflin commented May 10, 2022

I definitely expect that pressing Ctrl+Shift+F would focus the search box in the same manner that pressing Ctrl+F focuses the search-in-page search box. This would also be consistent with VS Code, VS, etc. I keep finding myself pressing Ctrl+Shift+F and typing a search term only to find out that I've been typing in the document.

BBazard added a commit to BBazard/marktext that referenced this issue Aug 21, 2022
@BBazard
fix: marktext#2294 Focus find-in-folder search box; unfocus with ESC
07a1afd
@BBazard BBazard linked a pull request Aug 21, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #2294 Focus find-in-folder search box; unfocus with ESC BBazard/marktext
2 participants
@Henry78 @Ziflin