-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: netBSD packaging build broken for 3.9 #28260
Comments
I'm not seeing a missing symbol in the logs, I'm seeing that one of our c-extensions did not get built/installed correctly. The module that is failing is https://github.com/matplotlib/matplotlib/blob/main/src/_c_internal_utils.cpp which does not use Agg (it is mostly some windows related code and checking if we have any sort of running X or wayland server available). We switched to building with meson for 3.9, I suspect that the packaging in netbsd will need to be updated to patch https://matplotlib.org/stable/install/dependencies.html for the current dependencies. I looked at https://github.com/NetBSD/pkgsrc/tree/trunk/graphics/py-matplotlib which I think is what you are using? I'm not familiar enough with netBSD's build tooling to diagnose what is wrong (I assume one of the |
I've put the update package at https://github.com/NetBSD/pkgsrc-wip/tree/master/py-matplotlib I think it's related to agg because of this:
which has in the middle a couple lines like
|
Maybe turn off LTO? We turn it on by default. |
Thank you, turning off LTO fixes the missing symbol problem! I still can't get the tests to run though. In both cases I install matplotlib. When I run py-test in the build directory, I get (see above):
in the collection step (5 times); when I run it somewhere else (not in the build directory), I get:
Here's the list of installed files matching
|
(That's with the pypi matplotlib 3.9.0 source files.) |
You need to install the test data; please read the release notes for the build change. |
Thank you for the pointer. I changed the meson arguments as suggested and many more files were installed.
The installed file has:
and the non-installed file (why is that even found?) is the same
Any ideas? |
Loading from the current directory is how pytest works by default; if you want to test the installed copy, you need to ask it with |
I just noticed this in the output; you probably need to set |
Thanks for the help.
some complain about missing dependencies like About Thanks for the help! |
Bug summary
Hi! I've tried updating the pkgsrc package for matplotlib to 3.9.0 and ran the self tests to confirm it works, but I got an error about a missing symbol. I think the symbol should come from the included external agg24-svn library. I see the following weird output in the build log:
I'm not sure what that wants to tell me.
Code for reproduction
Actual outcome
Expected outcome
Successful test.
Additional information
No response
Operating system
NetBSD 10.99.10/amd64
Matplotlib Version
3.9.0
Matplotlib Backend
fails due to missing symbol
Python version
3.12.3
Jupyter version
n/a
Installation
from source (.tar.gz)
The text was updated successfully, but these errors were encountered: