Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect and reject configurations where the service IP range overlaps with node IPs #364

Open
danderson opened this issue Dec 18, 2018 · 4 comments · May be fixed by #2404
Open

Detect and reject configurations where the service IP range overlaps with node IPs #364

danderson opened this issue Dec 18, 2018 · 4 comments · May be fixed by #2404
Assignees
@yiytan
Labels
bug cleanup help wanted

Comments

@danderson
Copy link
Contributor

Probably due to inadequate documentation, people think that they can define service IPs that overlap with node IPs. This breaks things in multiple ways (ARP poisoning in L2 mode, wrong kube-proxy rules executed in all modes...), and is not at all a supported mode of operation.

The controller should detect and reject such configurations, as well as refuse to allocate IPs if they overlap with node IPs.
@danderson danderson self-assigned this Dec 18, 2018
@ErwanMAS
Copy link

So if i have :

  • subset for service IP for metallb ( 192.X.Y.10-192.X.Y.20 ) .
  • all k8 nodes are using IP in the subset ( 192.X.Y.180-192.X.Y.220)
  • my network is 192.X.Y.0/24

This is working ?

@danderson
Copy link
Contributor Author

The IPs are not overlapping, so yes, this is fine.

@yiytan
Copy link

yiytan commented Apr 22, 2024

Can I work on this issue?

@fedepaol
Copy link
Member

Can I work on this issue?

sure!

@fedepaol fedepaol assigned fedepaol and yiytan and unassigned danderson and fedepaol Apr 22, 2024
tyiying pushed a commit to tyiying/metallb that referenced this issue May 16, 2024
@yiytan
metallb#364: Detect and reject configurations where the service IP ra…
1e23005 
…nge overlaps with node IPs
This was referenced May 16, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yiytan yiytan

Labels
bug cleanup help wanted
Projects
None yet
Milestone
No milestone
4 participants
@danderson @fedepaol @ErwanMAS @yiytan