Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] DiffEditor renders revert buttons on top of editor #4514

Open
1 of 2 tasks
yanny7 opened this issue May 17, 2024 · 1 comment
Open
1 of 2 tasks

[Bug] DiffEditor renders revert buttons on top of editor #4514

yanny7 opened this issue May 17, 2024 · 1 comment

Comments

@yanny7
Copy link

yanny7 commented May 17, 2024

Reproducible in vscode.dev or in VS Code Desktop?

  • Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

Monaco Editor Playground Link

https://microsoft.github.io/monaco-editor/playground.html?source=v0.48.0#XQAAAAI5AgAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscw0sePKVciAJM8XEuX7Os378jBGtVLkr6ryuhqvky-XZ9Sy0vyFSI1m9lYQpwqOsaKmhydYWIo-9hGbv_4wlPIsEpVooDN3UCCmiQC5FjKPxzaxh5hrHBH_dDuy7gpl4xVrSKRXH-NmrPZoJzyFwC-UYLbA8Z84Bw5ZNPVFqM9fExq8cqCEwa9UoLotEqB7tH53vSyKw2myEX6Vk0efXw6arZvrQDPiuU1wUw5GpDvAxxBaBFN7YtwdjV5am9PIELafk_5c10kI3mLLevzGbYJF7DN1oyZf7AZHZlVeJvaf7s49WDtWWJNtfYQpR3ZJls3-wPokm9adpH-9unhBw

Monaco Editor Playground Code

const originalModel = monaco.editor.createModel(
	/* set from `originalModel`: */ `hello world


asdfa

`,
	"text/plain"
);
const modifiedModel = monaco.editor.createModel(
	/* set from `modifiedModel`: */ `Hello World!



asdfo

`,
	"text/plain"
);

const diffEditor = monaco.editor.createDiffEditor(
	document.getElementById("container"),
	{
		originalEditable: false,
		automaticLayout: false,
		glyphMargin: true,
	}
);
diffEditor.setModel({
	original: originalModel,
	modified: modifiedModel,
});

Reproduction Steps

Paste provided code into playground

Actual (Problematic) Behavior

From version 0.48.0 are revert buttons rendered on top of editor.

Expected Behavior

Revert buttons are rendered in correct height on modified lines

Additional Context

No response

@yanny7 yanny7 changed the title [Bug] DiffEditor renders revert buttons on top of editor, instead on changed line [Bug] DiffEditor renders revert buttons on top of editor May 17, 2024
@yanny7
Copy link
Author

yanny7 commented May 17, 2024

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant