Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SymbolReader] Make symbol server timeout configurable #1895

Open
suprak opened this issue Aug 10, 2023 · 1 comment
Open

[SymbolReader] Make symbol server timeout configurable #1895

suprak opened this issue Aug 10, 2023 · 1 comment

Comments

@suprak
Copy link

suprak commented Aug 10, 2023

https://github.com/microsoft/perfview/blob/766a08ca8373d273d55da8b07147e7068e4d5f58/src/TraceEvent/Symbols/SymbolReader.cs#L1143C17-L1144C33

Working with PerfView on a slower internet environment and public symbol server frequently times out and gets blocked from additional attempts to resolve, leading to broken symbols.

FindSymbolFilePath: Time 27.2141736 sec. Timeout of 25 seconds exceeded for https://msdl.microsoft.com/download/symbols. Setting as dead server

SymbolResolver could have a property on it, say ServerTimeout or something.

@brianrob
Copy link
Member

I agree that something like this is worthwhile. At the same time, we probably ought to change the retry behavior to ensure that a failed request doesn't mark the server dead for minutes at a time. This used to be OK, but often now this is overkill, and worse, in server processes, this is just wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants