Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub re-login after refresh the page #6006

Open
boltonidze opened this issue May 17, 2024 · 3 comments
Open

GitHub re-login after refresh the page #6006

boltonidze opened this issue May 17, 2024 · 3 comments
Labels
info-needed Issue requires more information from poster

Comments

@boltonidze
Copy link

Hello!

We deploy our VSCode in k8s with jupyterhub (instead of running jupyterlab we run vscode pod for each user). Pod with vscode lives endless. Everything work fine, but after refresh the page GitHub pull request plugin ask to login again.

I try to understand is it possible to avoid login to GitHub after each page refresh?

  • Extension version: v0.88.1
  • VSCode Version: 1.89.1

In logs I see

2024-05-17 17:33:22.309 [info] Reading sessions from keychain...
2024-05-17 17:33:22.309 [info] Getting sessions for all scopes...
2024-05-17 17:33:22.309 [info] Got 0 sessions for ...
2024-05-17 17:33:22.309 [info] Getting sessions for all scopes...
2024-05-17 17:33:22.309 [info] Got 0 sessions for ...
2024-05-17 17:33:25.669 [info] Getting sessions for project,read:org,read:user,repo,user:email,workflow...
2024-05-17 17:33:25.670 [info] Got 0 sessions for project,read:org,read:user,repo,user:email,workflow...
2024-05-17 17:33:25.673 [info] Getting sessions for read:user,repo,user:email,workflow...
2024-05-17 17:33:25.673 [info] Got 0 sessions for read:user,repo,user:email,workflow...
2024-05-17 17:33:26.212 [info] Getting sessions for read:user,repo,user:email,workflow...
2024-05-17 17:33:26.213 [info] Got 0 sessions for read:user,repo,user:email,workflow...
2024-05-17 17:33:26.369 [info] Getting sessions for read:user,repo,user:email...
2024-05-17 17:33:26.369 [info] Got 0 sessions for read:user,repo,user:email...
2024-05-17 17:33:26.500 [info] Getting sessions for read:user,repo,user:email,workflow...
2024-05-17 17:33:26.500 [info] Got 0 sessions for read:user,repo,user:email,workflow...
2024-05-17 17:33:26.847 [info] Getting sessions for project,read:org,read:user,repo,user:email,workflow...
2024-05-17 17:33:26.847 [info] Got 0 sessions for project,read:org,read:user,repo,user:email,workflow...
2024-05-17 17:33:26.997 [info] Getting sessions for read:user,repo,user:email,workflow...
2024-05-17 17:33:26.997 [info] Got 0 sessions for read:user,repo,user:email,workflow...
2024-05-17 17:33:27.171 [info] Getting sessions for read:user,repo,user:email...
2024-05-17 17:33:27.171 [info] Got 0 sessions for read:user,repo,user:email...
2024-05-17 17:33:27.337 [info] Getting sessions for read:user,repo,user:email,workflow...
2024-05-17 17:33:27.338 [info] Got 0 sessions for read:user,repo,user:email,workflow...
2024-05-17 17:33:28.832 [info] Getting sessions for project,read:org,read:user,repo,user:email,workflow...
2024-05-17 17:33:28.832 [info] Got 0 sessions for project,read:org,read:user,repo,user:email,workflow...
2024-05-17 17:33:28.963 [info] Getting sessions for read:user,repo,user:email,workflow...
2024-05-17 17:33:28.963 [info] Got 0 sessions for read:user,repo,user:email,workflow...
2024-05-17 17:33:29.103 [info] Getting sessions for read:user,repo,user:email...
2024-05-17 17:33:29.103 [info] Got 0 sessions for read:user,repo,user:email...
2024-05-17 17:33:29.246 [info] Getting sessions for read:user,repo,user:email,workflow...
2024-05-17 17:33:29.246 [info] Got 0 sessions for read:user,repo,user:email,workflow...
2024-05-17 17:33:30.440 [info] Logging in for the following scopes: read:user repo user:email workflow
2024-05-17 17:33:30.566 [info] Trying device code flow... (read:user repo user:email workflow)
2024-05-17 17:33:58.039 [info] Getting user info...
2024-05-17 17:33:58.294 [info] Got account info!
2024-05-17 17:33:58.295 [info] Storing 1 sessions...
2024-05-17 17:33:58.348 [info] Reading sessions from keychain...
2024-05-17 17:33:58.348 [info] Stored 1 sessions!
2024-05-17 17:33:58.351 [info] Login success!
2024-05-17 17:33:58.457 [trace] Token acquired from secret storage.
2024-05-17 17:33:58.457 [info] Got stored sessions!
2024-05-17 17:33:58.457 [trace] Read the following session from the keychain with the following scopes: read:user repo user:email workflow
2024-05-17 17:33:58.458 [info] Got 1 verified sessions.
2024-05-17 17:33:58.686 [info] Getting sessions for project,read:org,read:user,repo,user:email,workflow...
2024-05-17 17:33:58.687 [info] Getting sessions for read:user,repo,user:email,workflow...
2024-05-17 17:33:58.687 [info] Got 0 sessions for project,read:org,read:user,repo,user:email,workflow...
2024-05-17 17:33:58.687 [info] Got 1 sessions for read:user,repo,user:email,workflow...
2024-05-17 17:33:58.903 [info] Getting sessions for read:user,repo,user:email,workflow...
2024-05-17 17:33:58.903 [info] Got 1 sessions for read:user,repo,user:email,workflow...
2024-05-17 17:33:59.547 [info] Getting sessions for read:user,repo,user:email,workflow...
2024-05-17 17:33:59.547 [info] Got 1 sessions for read:user,repo,user:email,workflow...

But after refresh a page token is missing again:

2024-05-17 17:36:01.475 [info] Reading sessions from keychain...
2024-05-17 17:36:01.475 [info] Getting sessions for all scopes...
2024-05-17 17:36:01.475 [info] Got 0 sessions for ...
2024-05-17 17:36:01.475 [info] Getting sessions for all scopes...
2024-05-17 17:36:01.475 [info] Got 0 sessions for ...
2024-05-17 17:36:04.516 [info] Getting sessions for project,read:org,read:user,repo,user:email,workflow...
2024-05-17 17:36:04.516 [info] Got 0 sessions for project,read:org,read:user,repo,user:email,workflow...
2024-05-17 17:36:04.548 [info] Getting sessions for read:user,repo,user:email,workflow...
2024-05-17 17:36:04.549 [info] Got 0 sessions for read:user,repo,user:email,workflow...
2024-05-17 17:36:04.946 [info] Getting sessions for read:user,repo,user:email,workflow...
2024-05-17 17:36:04.946 [info] Got 0 sessions for read:user,repo,user:email,workflow...
2024-05-17 17:36:05.116 [info] Getting sessions for read:user,repo,user:email...
2024-05-17 17:36:05.116 [info] Got 0 sessions for read:user,repo,user:email...
2024-05-17 17:36:05.393 [info] Getting sessions for read:user,repo,user:email,workflow...
2024-05-17 17:36:05.393 [info] Got 0 sessions for read:user,repo,user:email,workflow...
2024-05-17 17:36:05.754 [info] Getting sessions for project,read:org,read:user,repo,user:email,workflow...
2024-05-17 17:36:05.755 [info] Got 0 sessions for project,read:org,read:user,repo,user:email,workflow...
2024-05-17 17:36:05.897 [info] Getting sessions for read:user,repo,user:email,workflow...
2024-05-17 17:36:05.897 [info] Got 0 sessions for read:user,repo,user:email,workflow...
2024-05-17 17:36:06.044 [info] Getting sessions for read:user,repo,user:email...
2024-05-17 17:36:06.044 [info] Got 0 sessions for read:user,repo,user:email...
2024-05-17 17:36:06.200 [info] Getting sessions for read:user,repo,user:email,workflow...
2024-05-17 17:36:06.200 [info] Got 0 sessions for read:user,repo,user:email,workflow...
@alexr00
Copy link
Member

alexr00 commented May 27, 2024

@boltonidze are you using VS Code in your browser?

@alexr00 alexr00 added the info-needed Issue requires more information from poster label May 27, 2024
@boltonidze
Copy link
Author

Yes, that's true. We are deploying it to k8s with Juperyhub. After this the flow is the same as for Jupyterhub - users can open a bowser and run their own servers (pods) with VSCode. The problem is that we have GitHub Pull Request plugin, but when users refresh the page in his browser, they have to re-login to GitHub again.

@alexr00
Copy link
Member

alexr00 commented May 27, 2024

@TylerLeonhardt do you know why this might happen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
info-needed Issue requires more information from poster
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@boltonidze @alexr00