Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't Press Both Shift Keys at Once #520

Open
ForgotTheSemicolon opened this issue Aug 20, 2022 · 1 comment
Open

Can't Press Both Shift Keys at Once #520

ForgotTheSemicolon opened this issue Aug 20, 2022 · 1 comment

Comments

@ForgotTheSemicolon
Copy link

The keyboard input for Moonlight on my Chomebook will only recognize input from one Shift key at a time. If I press just the left Shift, it works, and if I press just the right Shift, it works, but if I press both at once, only one is recognized. I first noticed it while playing Epic Pinball via DosBox, but I reproduced the issue on a keyboard test website also. If I go to https://en.key-test.ru/ on my Chromebook, I can get both Shift keys on the screen to light up at the same time, but if I go there on the Windows desktop through Moonlight, I can only light up one Shift at a time.

@cgutman
Copy link
Member

cgutman commented Nov 7, 2022

I think this is related to the way NaCl sends us modifier events. Rather than send specific keycodes for Left Shift and Right Shift, it sends a single Shift key code that has flags that indicate left or right. When you press Right Shift while Left Shift is down, it comes in as a key repeat and is dropped.

Assuming we do actually get separate key up events for both keys, we might be able to work around these limitations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants