Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing theme setting does not apply correctly to all iPad windows #20332

Open
data-sync-user opened this issue May 19, 2024 · 3 comments
Open

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented May 19, 2024

Steps:

  1. Open multiple windows, ensure you in a normal (non-private) tab
  2. Open Settings, set Theme to manual and switch between Dark/Light

Expected: the theme change applies to all windows and all UI is updated.

Actual: only the window where the setting was changed is updated.

┆Issue is synchronized with this Jira Bug

@data-sync-user
Copy link
Collaborator Author

➤ Matt Reagan commented:

Note: I’m not sure exactly when this regressed, though I rolled back to a commit from 3/18 and could see that it was working correctly at that time. (Attached an example video of how it’s expected to work)

!themechange.mov|width=640,height=444,alt="themechange.mov"!

@data-sync-user
Copy link
Collaborator Author

➤ Matt Reagan commented:

cc Alina Moldovan This is the theme bug for multi-window that I mentioned in the KO. It should be fixed now.

@data-sync-user
Copy link
Collaborator Author

➤ Diana Andreea Barladeanu commented:

Verified as fixed on v9000 (42142), with iPad Air 3rd gen (17.5).

!RPReplay_Final1716639285.mp4|width=720,height=960,alt="RPReplay_Final1716639285.mp4"!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant