New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive .PHONY violation on variables #61

Open

dgeorge83616 opened this issue Nov 19, 2021 · 0 comments

dgeorge83616 commented Nov 19, 2021

checkmake/parser/parser.go

Lines 48 to 49 in ca982ae

    
           reFindSimpleVariable   = regexp.MustCompile("^([a-zA-Z]+) ?:=(.*)") 
        
           reFindExpandedVariable = regexp.MustCompile("^([a-zA-Z]+) ?=(.*)")

Those regex definitions don't recognize VAR=blah or VAR:=blahand flag such lines as needing.PHONY`.

    1 ifeq ($(OS), Windows_NT)
>>  2 MKDIR:=$(shell which mkdir.exe)
    3 else
~   4 MKDIR := mkdir
    5 endif

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment