Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten up use of special ports #340

Open
bocchino opened this issue Oct 13, 2023 · 1 comment
Open

Tighten up use of special ports #340

bocchino opened this issue Oct 13, 2023 · 1 comment
Labels
proposed feature A proposed new feature semantics Issues related to semantics spec Issues related to the FPP language specification

Comments

@bocchino
Copy link
Collaborator

bocchino commented Oct 13, 2023

Currently special ports for commands, telemetry, etc. are allowed even when there are no commands or telemetry channels defined. Possibly we should exclude this case, and throw an error when analyzing the model.

Related to #339.

@bocchino bocchino added semantics Issues related to semantics spec Issues related to the FPP language specification labels Oct 13, 2023
@bocchino bocchino added this to To do in Fixes and Enhancements via automation Oct 13, 2023
@timcanham
Copy link

timcanham commented Oct 13, 2023

For what it's worth, I've been wanting FPP to fail if the F Prime special ports and their FPP features (commands/telemetry/events) are not matched, but I was waiting for the new autocoder as the starting point. Not having them can introduce confusing errors downstream. In the past, if I didn't have anything yet for a feature, I created placeholders just so I can hook up the topology early.

@bocchino bocchino removed this from To do in Fixes and Enhancements Nov 16, 2023
@bocchino bocchino added this to To Do in Proposed Features via automation Nov 16, 2023
@bocchino bocchino added the proposed feature A proposed new feature label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposed feature A proposed new feature semantics Issues related to semantics spec Issues related to the FPP language specification
Projects
Development

No branches or pull requests

2 participants