Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FW_ARRAY_TO_STRING #375

Open
bocchino opened this issue Jan 4, 2024 · 0 comments
Open

Remove FW_ARRAY_TO_STRING #375

bocchino opened this issue Jan 4, 2024 · 0 comments
Labels
code generation Issues related to code generation
Projects
Fixes and Enhancements

Comments

@bocchino
Copy link
Collaborator

bocchino commented Jan 4, 2024

The compilation that is now conditioned on FW_ARRAY_TO_STRING should be conditioned on FW_SERIALIZABLE_TO_STRING. It doesn't make sense to treat arrays separately from structs, because structs can have arrays in them. In other words, FW_SERIALIZABLE_TO_STRING should not govern just the code gen for structs: it should govern the code gen of all serializable types.

Related to #303.
@bocchino bocchino added the code generation Issues related to code generation label Jan 4, 2024
@bocchino bocchino added this to To do in Fixes and Enhancements via automation Jan 4, 2024
@bocchino bocchino mentioned this issue Jan 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code generation Issues related to code generation
Projects
Fixes and Enhancements
  
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bocchino