Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .join() Calls for Consistency With nasa/fprime#2672 #424

Closed
LeStarch opened this issue May 6, 2024 · 1 comment
Closed

Update .join() Calls for Consistency With nasa/fprime#2672 #424

LeStarch opened this issue May 6, 2024 · 1 comment
Assignees
@LeStarch
Labels
code generation Issues related to code generation
Projects
Fixes and Enhancements
Milestone
v2.1.0

Comments

@LeStarch
Copy link
Collaborator

LeStarch commented May 6, 2024

nasa/fprime#2672 refactors the .join call to remove the unused nullptr argument. FPP should respect this and avoid the old deprecated style.
@LeStarch LeStarch self-assigned this May 6, 2024
@bocchino bocchino added the code generation Issues related to code generation label May 6, 2024
@bocchino bocchino added this to To do in Fixes and Enhancements via automation May 6, 2024
@bocchino bocchino added this to the v2.1.0 milestone May 6, 2024
@LeStarch LeStarch mentioned this issue May 6, 2024
Merged
@bocchino bocchino moved this from To do to In progress in Fixes and Enhancements May 23, 2024
@bocchino
Copy link
Collaborator

Done in #425.

Fixes and Enhancements automation moved this from In progress to Done May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeStarch LeStarch

Labels
code generation Issues related to code generation
Projects
Fixes and Enhancements
  
Done
Milestone
v2.1.0
Development

No branches or pull requests
2 participants
@LeStarch @bocchino