Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly Support ERT Ordering #2650

Open
LeStarch opened this issue Mar 28, 2024 · 1 comment
Open

Properly Support ERT Ordering #2650

LeStarch opened this issue Mar 28, 2024 · 1 comment
Labels
enhancement Test API Integration test API

Comments

@LeStarch
Copy link
Collaborator

F´ Version
Affected Component

Feature Description

In order to properly support ERT ordering, I recommend:

  1. Add a TimeType field to the SysData class and add an accessor for get_ert_time().
  2. Have the GDS record ERT at some point.
  3. Preserve the use of the fsw_order argument in the test API's constructor and sub-history functions by passing the fsw_order argument to the chronological history constructor.
  4. Modify chronological history to choose whether to use get_time() or get_ert_time() for its ordering/returning operations:
@LeStarch LeStarch added enhancement CI Issues pertaining to Continuous Integration Test API Integration test API and removed CI Issues pertaining to Continuous Integration labels Mar 28, 2024
@LeStarch
Copy link
Collaborator Author

As part of the work to add ERT and have chronological histories work for both ERT and FSW orders, histories should be updated to have a get_current_marker() method. This will allow the histories to specify the best way to mark a position with respect to their own implementations. For reference: ChronologicalHistories should use a TimeType, Ram and Test History should use an index.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Test API Integration test API
Projects
None yet
Development

No branches or pull requests

1 participant