New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Artists with non-English name may not be able to obtain image #2377
Comments
Is this an issue with Navidrome or with the Spotify API? |
I think it should be Navidrome , I have found the correct item in his response when I use Spotify API |
I've looked into this, some Japanese artist can still their images obtained. However there is an internal checking whether the searched artist name is the same as artist name from metadata: core/agents/spotify/spotify.go
For some artist, artist name obtained from Spotify API is romanized, for example: 平沢進 is listed as Susumu Hirasawa. Not sure if there is a localization setting in the API, as the response JSON you attach is properly listed in Japanese |
There is a "market" parameter for the spotify search API, but I'm not sure it will help as in the documentation it says that the parameter only changes whether the item is available in certain countries or not. Also the country region of the the user will take precedence over this parameter. For reference: https://developer.spotify.com/documentation/web-api/reference/search I guess the fix would depend whether we want to just trust the first search result (as we did, but right now we double check whether it is the same as our file's metadata - which is the root cause of the bug) or maybe we could refer to other information to get the proper artist image I would like to work on this issue after we decided which approach we should take |
This issue has been automatically marked as stale because it has not had recent activity. The resources of the Navidrome team are limited, and so we are asking for your help. |
just commenting to avoid staleness. I am thinking about using the |
So other japanese devs have also faced this issue and have found that adding a EDIT: |
Adding an artist.jpg should work too, if all files for that artist are in/below that Artist folder. |
I think the correct behaviour is to use the language tag from the file. We don't want to spam Spotify's API to avoid bumping into rate limits or worse, having them blocking Navidrome for all users! And it will be only one request per artist. Once we get a response from Spotify, the images are saved in the cache. If anyone wants to work on this, they are more than welcome :)
@vnghia, currently the way artist images are resolved is described in the link posted by @metalheim above: https://www.navidrome.org/docs/usage/artwork/#artists |
I've created a PR utilizing the "SortArtistName" which should be in Latin characters for any artist. I've noticed just now that navidrome has musicbrainz integration, so I guess that is also another way we could query/match the artist name, but the PR addresses most of the problems I had initially. |
I confirm that:
Version
0.49.3
Current Behavior
Log
level=warning msg="Artist not found in Spotify" artist="豊永利行"
level=warning msg="Artist not found in Spotify" artist="米津玄師"
level=warning msg="Artist not found in Spotify" artist="平沢進"
One of Spotify Respond
平沢進
Request URL:
https://api.spotify.com/v1/search?q=%E5%B9%B3%E6%B2%A2%E9%80%B2&type=artist
Respond:
Expected Behavior
non-English name can also be able to obtain image
Steps To Reproduce
No response
Environment
No response
How Navidrome is installed?
Docker
Configuration
No response
Relevant log output
No response
Anything else?
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: