Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow maximize & fullscreen in modal #164

Open
SamMousa opened this issue Aug 30, 2023 · 1 comment
Open

Allow maximize & fullscreen in modal #164

SamMousa opened this issue Aug 30, 2023 · 1 comment

Comments

@SamMousa
Copy link
Contributor

When in modal mode all buttons except close are hidden.
It makes sense to hide minimize (since it is a modal), however maximize and fullscreen could make perfect sense.

I propose to add a configuration for this:

buttons: {
   minimize: false,
   maximize: true,
   fullscreen: true,
   close: true
}

Setting modal to true would change the default values for buttons but explicit config would always have priority.

@gvangass
Copy link

gvangass commented Sep 7, 2023

I second this proposal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants