Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking call chain for the show and hide methods #171

Open
ilkiri23 opened this issue Nov 28, 2023 · 0 comments
Open

Breaking call chain for the show and hide methods #171

ilkiri23 opened this issue Nov 28, 2023 · 0 comments
Assignees
@ts-thomas
Labels
bug Something isn't working

Comments

@ilkiri23
Copy link

Hi, thank you for the library! We saved a lot of time with it

Problem
When I try to execute a call chain like winbox.show().maximize() for a non-hidden winbox instance, I get an error Cannot read properties of undefined (reading 'maximize') because show method returns this only for a hidden instance or when a state false is passed. The same situation with hide
v 0.2.82

Is this expected behavior? If not, I'll make a PR
@ts-thomas ts-thomas added the bug Something isn't working label Dec 21, 2023
@ts-thomas ts-thomas self-assigned this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ts-thomas ts-thomas

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ts-thomas @ilkiri23