Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using getters and setters #1026

Open
another-m00 opened this issue Sep 13, 2023 · 0 comments
Open

Consider using getters and setters #1026

another-m00 opened this issue Sep 13, 2023 · 0 comments

Comments

@another-m00
Copy link
Contributor

another-m00 commented Sep 13, 2023

It is relatively easy to implement getters and setters to make using the library less repetitive/painful.
They can shorten set<value>() calls to just an assigment and get<value>() calls to a single property access.
I'd also consider using default objects for the obvous parts such as the Central widget of mainWindow, but I dont know yet, how much of that is already implemented in Qt.
However this modification will impact the memory, so I could either do this as a fork, or a separate plugin library, so we dont frighten the old fashioned programmers.

I am fully willing to make the typescript wrapper modifications to this but it'll take a while since I can only work on this in my free time, and my current prioritiy is to find and sqash the cause of #1012.

The idea would be that on the cpp level nothing would change and the new wrapper just would use the old functions, leaving their full functionality. But the result should be a lot more like DOM in browser JS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant